support removing empty cache directories #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fnichol was there any reason that you didn't recursively delete the contents of this directory? Is it safe to do so? |
|
@reset No, it's okay to recursively delete the contents of that directory--not even sure why I didn't originally. In fact, after I tweaked some of the download logic (already in master), it's pretty safe to delete that directory itself if desired--that directory will be created just before it's used on artifact download. Same for the key cache under |
|
@fnichol thanks for the response! |
|
📌 Commit b19a584 has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
May 24, 2016
Pull request: #550 Approved by: reset
|
☀️ Test successful - travis |
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
Pull request: #550 Approved by: reset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"rm $HAB_STUDIO_ROOT$HAB_CACHE_ARTIFACT_PATH/*" with an empty directory fails the script.