Use --listen-http rather than --listen-sidecar
#574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the `--listen-sidecar` flag to be `--listen-http`. It doesn't update all the internals to reflect it (since it's still the "sidecar" module) - but I tried to change everywhere you reference the configuration option. It also is the first time the director has been updated post-handlebars conversion, so it updated the Cargo.lock. Signed-off-by: Adam Jacob <[email protected]>
|
By analyzing the blame information on this pull request, we identified @fnichol, @metadave, @reset, @juliandunn and @adamhjk to be potential reviewers |
|
📌 Commit fbc0e41 has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
May 27, 2016
This PR updates the `--listen-sidecar` flag to be `--listen-http`. It doesn't update all the internals to reflect it (since it's still the "sidecar" module) - but I tried to change everywhere you reference the configuration option. It also is the first time the director has been updated post-handlebars conversion, so it updated the Cargo.lock. Signed-off-by: Adam Jacob <[email protected]> Pull request: #574 Approved by: metadave
|
☀️ Test successful - travis |
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
This PR updates the `--listen-sidecar` flag to be `--listen-http`. It doesn't update all the internals to reflect it (since it's still the "sidecar" module) - but I tried to change everywhere you reference the configuration option. It also is the first time the director has been updated post-handlebars conversion, so it updated the Cargo.lock. Signed-off-by: Adam Jacob <[email protected]> Pull request: #574 Approved by: metadave
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
--listen-sidecarflag to be--listen-http. Itdoesn't update all the internals to reflect it (since it's still the
"sidecar" module) - but I tried to change everywhere you reference the
configuration option.
It also is the first time the director has been updated post-handlebars
conversion, so it updated the Cargo.lock.
Signed-off-by: Adam Jacob [email protected]