Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hab] Support multiple args on pkg install & artifact upload. #576

Merged

Conversation

fnichol
Copy link
Collaborator

@fnichol fnichol commented May 27, 2016

This feature is in line with the behavior of other package managers, that is:

As a user, I want to install multiple packages with one command line invocation like apt-get install redis-server git-core sudo.

With this change, multiple arguments are accepted on the hab pkg install and hab artifact upload subcommands. Remembering that it is (in general) your shell that unrolls file globs before passing the
argments to the process, we can now have highly desirable workflows such as:

hab pkg install ./results/*.hart
hab artifact upload ./results/*.hart

The pkg install subcommand in particular treats each argument as an artifact-or-pkg-ident, meaning you can mix and match local arifacts with published packages, as in:

hab pkg install ./results/*.hart core/hab-sup

gif-keyboard-8519441934611072433

This feature is in line with the behavior of other package managers,
that is:

> As a user, I want to install multiple packages with one command line
> invocation like `apt-get install redis-server git-core sudo`.

With this change, multiple arguments are accepted on the `hab pkg
install` and `hab artifact upload` subcommands. Remembering that it is
(in general) your shell that unrolls file globs before passing the
argments to the process, we can now have highly desirable workflows such
as:

    hab pkg install ./results/*.hart
    hab artifact upload ./results/*.hart

The `pkg install` subcommand in particular treats each argument as an
artifact-or-pkg-ident, meaning you can mix and match local arifacts with
published packages, as in:

    hab pkg install ./results/*.hart core/hab-sup

Signed-off-by: Fletcher Nichol <[email protected]>
@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @metadave and @adamhjk to be potential reviewers

@bookshelfdave
Copy link
Contributor

@thesentinels r+

nice touch!

gif-keyboard-8480677239055927726

@thesentinels
Copy link
Contributor

📌 Commit 7a17ed3 has been approved by metadave

@thesentinels
Copy link
Contributor

⌛ Testing commit 7a17ed3 with merge c3916ed...

thesentinels pushed a commit that referenced this pull request May 27, 2016
This feature is in line with the behavior of other package managers,
that is:

> As a user, I want to install multiple packages with one command line
> invocation like `apt-get install redis-server git-core sudo`.

With this change, multiple arguments are accepted on the `hab pkg
install` and `hab artifact upload` subcommands. Remembering that it is
(in general) your shell that unrolls file globs before passing the
argments to the process, we can now have highly desirable workflows such
as:

    hab pkg install ./results/*.hart
    hab artifact upload ./results/*.hart

The `pkg install` subcommand in particular treats each argument as an
artifact-or-pkg-ident, meaning you can mix and match local arifacts with
published packages, as in:

    hab pkg install ./results/*.hart core/hab-sup

Signed-off-by: Fletcher Nichol <[email protected]>

Pull request: #576
Approved by: metadave
@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit 7a17ed3 into master May 27, 2016
@fnichol fnichol deleted the fnichol/hab-multiple-args-on-install-and-upload branch May 27, 2016 23:27
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
This feature is in line with the behavior of other package managers,
that is:

> As a user, I want to install multiple packages with one command line
> invocation like `apt-get install redis-server git-core sudo`.

With this change, multiple arguments are accepted on the `hab pkg
install` and `hab artifact upload` subcommands. Remembering that it is
(in general) your shell that unrolls file globs before passing the
argments to the process, we can now have highly desirable workflows such
as:

    hab pkg install ./results/*.hart
    hab artifact upload ./results/*.hart

The `pkg install` subcommand in particular treats each argument as an
artifact-or-pkg-ident, meaning you can mix and match local arifacts with
published packages, as in:

    hab pkg install ./results/*.hart core/hab-sup

Signed-off-by: Fletcher Nichol <[email protected]>

Pull request: #576
Approved by: metadave
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants