[studio] The Studio Docker image build script has a no-args default. #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @adamhjk to be a potential reviewer |
| @@ -43,12 +44,13 @@ if ! command -v hab >/dev/null; then | |||
| exit 9 | |||
| fi | |||
|
|
|||
| tmp_root="$(mktemp -t -d "$(basename $0)-XXXX")" | |||
| tmp_root="$(mktemp -d -t "$(basename $0)-XXXX")" | |||
There was a problem hiding this comment.
I like the cut of your jib.
There was a problem hiding this comment.
I think this was the source of the Linux/Mac incompatibility when we've been using mktemp. Swapping those 2 flags make this work on both Linux and Mac, yippee!
|
📌 Commit 06daa92 has been approved by |
|
☔ The latest upstream changes (presumably c3916ed) made this pull request unmergeable. Please resolve the merge conflicts. |
This will make building the Docker image easier: you get a default image with default behavior. If you want to customize the versions of hab, Studio or other, then provide arguments to the script. Signed-off-by: Fletcher Nichol <[email protected]>
fnichol
force-pushed
the
fnichol/default-studio-docker-build
branch
from
06daa92 to
c42ebfa
Compare
|
📌 Commit c42ebfa has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
May 28, 2016
This will make building the Docker image easier: you get a default image with default behavior. If you want to customize the versions of hab, Studio or other, then provide arguments to the script. Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #579 Approved by: fnichol
|
☀️ Test successful - travis |
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
This will make building the Docker image easier: you get a default image with default behavior. If you want to customize the versions of hab, Studio or other, then provide arguments to the script. Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #579 Approved by: fnichol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make building the Docker image easier: you get a default image
with default behavior. If you want to customize the versions of hab,
Studio or other, then provide arguments to the script.