README Clarifications #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @smith, @adamhjk, @fnichol, @irvingpop and @metadave to be potential reviewers |
|
☔ The latest upstream changes (presumably be0e518) made this pull request unmergeable. Please resolve the merge conflicts. |
| @@ -220,9 +221,12 @@ Each commit must include a DCO which looks like this | |||
|
|
|||
| `Signed-off-by: Joe Smith <[email protected]>` | |||
|
|
|||
| The project requires that the name used is your real name. No contributions utilizing pseudonyms will be accepted nor will anonymous contributions. | |||
| The project requires that the name used is your real name. No contributions utilizing pseudonyms | |||
There was a problem hiding this comment.
This last sentence should really be written "Neither anonymous contributors nor those utilizing pseudonyms will be accepted."
added 3 commits
May 29, 2016 18:20
Signed-off-by: Nathen Harvey <[email protected]>
Signed-off-by: Nathen Harvey <[email protected]>
Signed-off-by: Nathen Harvey <[email protected]>
|
📌 Commit 559858a has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
May 29, 2016
Signed-off-by: Nathen Harvey <[email protected]> Pull request: #585 Approved by: juliandunn
thesentinels
pushed a commit
that referenced
this pull request
May 29, 2016
Signed-off-by: Nathen Harvey <[email protected]> Pull request: #585 Approved by: juliandunn
thesentinels
pushed a commit
that referenced
this pull request
May 29, 2016
Signed-off-by: Nathen Harvey <[email protected]> Pull request: #585 Approved by: juliandunn
|
☀️ Test successful - travis |
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
Signed-off-by: Nathen Harvey <[email protected]> Pull request: #585 Approved by: juliandunn
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
Signed-off-by: Nathen Harvey <[email protected]> Pull request: #585 Approved by: juliandunn
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
Signed-off-by: Nathen Harvey <[email protected]> Pull request: #585 Approved by: juliandunn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor copy and formatting changes.
Clarify instructions for building a sample plan by creating a key
hab origin key generate myoriginand adding that key as an environment variable,export HAB_ORIGIN=myorigin.