Move Makefile variable def's to the top. #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like there are parts of a Makefile that are parsed from top to bottom. The last refactoring of the Makefile, which moved the `IN_DOCKER` logic nearer to the bottom caused the `ifneq` blocks to not be evaluated in time. The fix was to move this back up to the top which sadly reduces the Makefile's readability, but at least it's correct again. Sorry, y'all! Signed-off-by: Fletcher Nichol <[email protected]>
|
By analyzing the blame information on this pull request, we identified @adamhjk, @jtimberman, @reset and @metadave to be potential reviewers |
|
📌 Commit 0421bcb has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
May 29, 2016
Looks like there are parts of a Makefile that are parsed from top to bottom. The last refactoring of the Makefile, which moved the `IN_DOCKER` logic nearer to the bottom caused the `ifneq` blocks to not be evaluated in time. The fix was to move this back up to the top which sadly reduces the Makefile's readability, but at least it's correct again. Sorry, y'all! Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #587 Approved by: juliandunn
|
☀️ Test successful - travis |
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
Looks like there are parts of a Makefile that are parsed from top to bottom. The last refactoring of the Makefile, which moved the `IN_DOCKER` logic nearer to the bottom caused the `ifneq` blocks to not be evaluated in time. The fix was to move this back up to the top which sadly reduces the Makefile's readability, but at least it's correct again. Sorry, y'all! Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #587 Approved by: juliandunn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like there are parts of a Makefile that are parsed from top to
bottom. The last refactoring of the Makefile, which moved the
IN_DOCKERlogic nearer to the bottom caused theifneqblocks to notbe evaluated in time. The fix was to move this back up to the top which
sadly reduces the Makefile's readability, but at least it's correct
again. Sorry, y'all!
Signed-off-by: Fletcher Nichol [email protected]