Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server-jre to core plans #595

Merged
merged 1 commit into from
Jun 1, 2016
Merged

Add server-jre to core plans #595

merged 1 commit into from
Jun 1, 2016

Conversation

elliott-davis
Copy link
Contributor

  • Add a plan to build java jre 8

Signed-off-by: Elliott Davis [email protected]

@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @adamhjk to be a potential reviewer

pkg_shasum=30608baff3bb3b09ea65fab603aae1c58f1381d7bb9d1b9af3dec9d499cabcc3
pkg_filename=jdk-${pkg_version}-linux-x64.tar.gz

pkg_license=('http://www.oracle.com/technetwork/java/javase/terms/license/index.html')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per @reset's comments last week on a plan I was working on, this maybe should be, "Oracle Binary Code License Agreement for the Java SE Platform Products and JavaFX"?

@juliandunn
Copy link
Contributor

@elliott-davis if you rebase off master this should turn green now.

* Add a plan to build java jre 8

Signed-off-by: Elliott Davis <[email protected]>
@elliott-davis
Copy link
Contributor Author

@juliandunn updated and passed - thanks for the protip

@juliandunn
Copy link
Contributor

@thesentinels r+

@thesentinels
Copy link
Contributor

📌 Commit 234509c has been approved by juliandunn

@thesentinels
Copy link
Contributor

⌛ Testing commit 234509c with merge 1c6039c...

thesentinels pushed a commit that referenced this pull request Jun 1, 2016
* Add a plan to build java jre 8

Signed-off-by: Elliott Davis <[email protected]>

Pull request: #595
Approved by: juliandunn
@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit 234509c into habitat-sh:master Jun 1, 2016
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
* Add a plan to build java jre 8

Signed-off-by: Elliott Davis <[email protected]>

Pull request: #595
Approved by: juliandunn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants