Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure unzip declares its bin dir #598

Merged
merged 1 commit into from
Jun 1, 2016
Merged

Ensure unzip declares its bin dir #598

merged 1 commit into from
Jun 1, 2016

Conversation

schisamo
Copy link
Contributor

@schisamo schisamo commented Jun 1, 2016

Without this change the binaries that ship in the package will not be available on PATH.

@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @adamhjk to be a potential reviewer

@schisamo
Copy link
Contributor Author

schisamo commented Jun 1, 2016

@juliandunn We'll need to publish a new unzip package after this is merged. Without it *.zip source artifacts are not properly expanded...for example:

artifactory-pro: Unpacking jfrog-artifactory-pro-4.8.0.zip
/hab/pkgs/core/hab-plan-build/0.6.0/20160531151257/bin/hab-plan-build: line 1225: unzip: command not found
   artifactory-pro: Build time: 0m3s
   artifactory-pro: Exiting on error

@fnichol
Copy link
Collaborator

fnichol commented Jun 1, 2016

@schisamo You got, good catch! I bet this is an old Plan.

Can you rebase against master and repush? That should clear the CI failure and I'll move it through.

Without this change the binaries that ship in the package will not be
available on `PATH`.
@schisamo
Copy link
Contributor Author

schisamo commented Jun 1, 2016

@fnichol done and done

@juliandunn
Copy link
Contributor

@thesentinels r+

@thesentinels
Copy link
Contributor

📌 Commit fd8c3e5 has been approved by juliandunn

@thesentinels
Copy link
Contributor

⌛ Testing commit fd8c3e5 with merge 17f5f69...

thesentinels pushed a commit that referenced this pull request Jun 1, 2016
Without this change the binaries that ship in the package will not be
available on `PATH`.

Pull request: #598
Approved by: juliandunn
@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit fd8c3e5 into habitat-sh:master Jun 1, 2016
@schisamo schisamo deleted the schisamo/unzip-bin-path branch June 1, 2016 14:49
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Without this change the binaries that ship in the package will not be
available on `PATH`.

Pull request: #598
Approved by: juliandunn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants