Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing new branding/design on nav and footer #603

Merged
merged 12 commits into from
Jun 1, 2016

Conversation

magwalk
Copy link
Contributor

@magwalk magwalk commented Jun 1, 2016

Also includes adding the fonts to our repo instead of hosting them on Google Fonts.

screen shot 2016-06-01 at 9 24 48 am
screen shot 2016-06-01 at 9 25 04 am
screen shot 2016-06-01 at 9 26 59 am

magwalk added 3 commits June 1, 2016 09:24
Updates the styles, markup, and scripts to reflect the new
design.

Signed-off-by: Maggie Walker <[email protected]>
Updates header font to Montserrat Alternates, also adds a /fonts
directory for us to self-host our fonts instead of importing them
from Google Fonts.

Signed-off-by: Maggie Walker <[email protected]>
Also modifies some of the styling for headings/paragraphs in
Try Habitat to be more specific to that section, since the
styles were being applied too globally.

Signed-off-by: Maggie Walker <[email protected]>
@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @cwebberOps and @ryankeairns to be potential reviewers

@ryankeairns
Copy link
Contributor

ryankeairns commented Jun 1, 2016

@magwalk this is sooooo great, nice work!

Just a few edits/suggestions:

  • the 'Try the Demo' button in the top nav should link to /try not /tutorials
  • add the drop shadow on the mobile nav div/bg when it expands down
  • let's change the default link color to the Hab green #87B09A instead of orange
  • can the footer bg image/pattern repeat horizontally?
  • habitat logo in the footer should link to home

Thanks :)

@@ -0,0 +1,43 @@
@font-face {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for the self-hosted folks!

magwalk added 4 commits June 1, 2016 09:59
Also modifies the logic of the mobile nav slightly to support
this new styling.

Signed-off-by: Maggie Walker <[email protected]>
Reflects new branding identity.

Signed-off-by: Maggie Walker <[email protected]>
@ryankeairns
Copy link
Contributor

ryankeairns commented Jun 1, 2016

@magwalk Those all look great! Discovered two more tweaks:

  • add top margin above the footer: rem-calc(90)
  • the fixed mobile nav needs a drop shadow too (after you scroll a bit; when in the unexpanded state)

Thanks

magwalk added 3 commits June 1, 2016 10:26
Since this styling is only used in the footer cta, it is now only
applied to that specific class.

Signed-off-by: Maggie Walker <[email protected]>
Signed-off-by: Maggie Walker <[email protected]>
@ryankeairns
Copy link
Contributor

lgtm, but I can't r+
@smith can you assist with that?

@bookshelfdave
Copy link
Contributor

wow, looks super nice!

@cwebberOps
Copy link
Contributor

@thesentinels r+

2 similar comments
@cwebberOps
Copy link
Contributor

@thesentinels r+

@juliandunn
Copy link
Contributor

@thesentinels r+

@thesentinels
Copy link
Contributor

📌 Commit 17ed766 has been approved by juliandunn

@cwebberOps
Copy link
Contributor

@thesentinels r+

@thesentinels
Copy link
Contributor

💡 This pull request was already approved, no need to approve it again.

@thesentinels
Copy link
Contributor

📌 Commit 17ed766 has been approved by cwebberOps

@thesentinels
Copy link
Contributor

⌛ Testing commit 17ed766 with merge e7886a3...

thesentinels pushed a commit that referenced this pull request Jun 1, 2016
Updates the styles, markup, and scripts to reflect the new
design.

Signed-off-by: Maggie Walker <[email protected]>

Pull request: #603
Approved by: cwebberOps
thesentinels pushed a commit that referenced this pull request Jun 1, 2016
Updates header font to Montserrat Alternates, also adds a /fonts
directory for us to self-host our fonts instead of importing them
from Google Fonts.

Signed-off-by: Maggie Walker <[email protected]>

Pull request: #603
Approved by: cwebberOps
thesentinels pushed a commit that referenced this pull request Jun 1, 2016
Also modifies some of the styling for headings/paragraphs in
Try Habitat to be more specific to that section, since the
styles were being applied too globally.

Signed-off-by: Maggie Walker <[email protected]>

Pull request: #603
Approved by: cwebberOps
thesentinels pushed a commit that referenced this pull request Jun 1, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #603
Approved by: cwebberOps
thesentinels pushed a commit that referenced this pull request Jun 1, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #603
Approved by: cwebberOps
thesentinels pushed a commit that referenced this pull request Jun 1, 2016
Also modifies the logic of the mobile nav slightly to support
this new styling.

Signed-off-by: Maggie Walker <[email protected]>

Pull request: #603
Approved by: cwebberOps
thesentinels pushed a commit that referenced this pull request Jun 1, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #603
Approved by: cwebberOps
thesentinels pushed a commit that referenced this pull request Jun 1, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #603
Approved by: cwebberOps
thesentinels pushed a commit that referenced this pull request Jun 1, 2016
Reflects new branding identity.

Signed-off-by: Maggie Walker <[email protected]>

Pull request: #603
Approved by: cwebberOps
thesentinels pushed a commit that referenced this pull request Jun 1, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #603
Approved by: cwebberOps
thesentinels pushed a commit that referenced this pull request Jun 1, 2016
Since this styling is only used in the footer cta, it is now only
applied to that specific class.

Signed-off-by: Maggie Walker <[email protected]>

Pull request: #603
Approved by: cwebberOps
thesentinels pushed a commit that referenced this pull request Jun 1, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #603
Approved by: cwebberOps
@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit 17ed766 into master Jun 1, 2016
@magwalk magwalk deleted the mwalker/redesign branch June 2, 2016 22:51
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Updates the styles, markup, and scripts to reflect the new
design.

Signed-off-by: Maggie Walker <[email protected]>

Pull request: #603
Approved by: cwebberOps
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Updates header font to Montserrat Alternates, also adds a /fonts
directory for us to self-host our fonts instead of importing them
from Google Fonts.

Signed-off-by: Maggie Walker <[email protected]>

Pull request: #603
Approved by: cwebberOps
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Also modifies some of the styling for headings/paragraphs in
Try Habitat to be more specific to that section, since the
styles were being applied too globally.

Signed-off-by: Maggie Walker <[email protected]>

Pull request: #603
Approved by: cwebberOps
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #603
Approved by: cwebberOps
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #603
Approved by: cwebberOps
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Also modifies the logic of the mobile nav slightly to support
this new styling.

Signed-off-by: Maggie Walker <[email protected]>

Pull request: #603
Approved by: cwebberOps
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #603
Approved by: cwebberOps
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #603
Approved by: cwebberOps
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Reflects new branding identity.

Signed-off-by: Maggie Walker <[email protected]>

Pull request: #603
Approved by: cwebberOps
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #603
Approved by: cwebberOps
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Since this styling is only used in the footer cta, it is now only
applied to that specific class.

Signed-off-by: Maggie Walker <[email protected]>

Pull request: #603
Approved by: cwebberOps
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #603
Approved by: cwebberOps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants