-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing new branding/design on nav and footer #603
Conversation
Updates the styles, markup, and scripts to reflect the new design. Signed-off-by: Maggie Walker <[email protected]>
Updates header font to Montserrat Alternates, also adds a /fonts directory for us to self-host our fonts instead of importing them from Google Fonts. Signed-off-by: Maggie Walker <[email protected]>
Also modifies some of the styling for headings/paragraphs in Try Habitat to be more specific to that section, since the styles were being applied too globally. Signed-off-by: Maggie Walker <[email protected]>
By analyzing the blame information on this pull request, we identified @cwebberOps and @ryankeairns to be potential reviewers |
Signed-off-by: Maggie Walker <[email protected]>
@magwalk this is sooooo great, nice work! Just a few edits/suggestions:
Thanks :) |
Signed-off-by: Maggie Walker <[email protected]>
@@ -0,0 +1,43 @@ | |||
@font-face { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay for the self-hosted folks!
Also modifies the logic of the mobile nav slightly to support this new styling. Signed-off-by: Maggie Walker <[email protected]>
Signed-off-by: Maggie Walker <[email protected]>
Signed-off-by: Maggie Walker <[email protected]>
Reflects new branding identity. Signed-off-by: Maggie Walker <[email protected]>
@magwalk Those all look great! Discovered two more tweaks:
Thanks |
Signed-off-by: Maggie Walker <[email protected]>
Since this styling is only used in the footer cta, it is now only applied to that specific class. Signed-off-by: Maggie Walker <[email protected]>
Signed-off-by: Maggie Walker <[email protected]>
lgtm, but I can't |
wow, looks super nice! |
2 similar comments
📌 Commit 17ed766 has been approved by |
💡 This pull request was already approved, no need to approve it again.
|
📌 Commit 17ed766 has been approved by |
Updates the styles, markup, and scripts to reflect the new design. Signed-off-by: Maggie Walker <[email protected]> Pull request: #603 Approved by: cwebberOps
Updates header font to Montserrat Alternates, also adds a /fonts directory for us to self-host our fonts instead of importing them from Google Fonts. Signed-off-by: Maggie Walker <[email protected]> Pull request: #603 Approved by: cwebberOps
Also modifies some of the styling for headings/paragraphs in Try Habitat to be more specific to that section, since the styles were being applied too globally. Signed-off-by: Maggie Walker <[email protected]> Pull request: #603 Approved by: cwebberOps
Signed-off-by: Maggie Walker <[email protected]> Pull request: #603 Approved by: cwebberOps
Signed-off-by: Maggie Walker <[email protected]> Pull request: #603 Approved by: cwebberOps
Also modifies the logic of the mobile nav slightly to support this new styling. Signed-off-by: Maggie Walker <[email protected]> Pull request: #603 Approved by: cwebberOps
Signed-off-by: Maggie Walker <[email protected]> Pull request: #603 Approved by: cwebberOps
Signed-off-by: Maggie Walker <[email protected]> Pull request: #603 Approved by: cwebberOps
Reflects new branding identity. Signed-off-by: Maggie Walker <[email protected]> Pull request: #603 Approved by: cwebberOps
Signed-off-by: Maggie Walker <[email protected]> Pull request: #603 Approved by: cwebberOps
Since this styling is only used in the footer cta, it is now only applied to that specific class. Signed-off-by: Maggie Walker <[email protected]> Pull request: #603 Approved by: cwebberOps
Signed-off-by: Maggie Walker <[email protected]> Pull request: #603 Approved by: cwebberOps
☀️ Test successful - travis |
Updates the styles, markup, and scripts to reflect the new design. Signed-off-by: Maggie Walker <[email protected]> Pull request: #603 Approved by: cwebberOps
Updates header font to Montserrat Alternates, also adds a /fonts directory for us to self-host our fonts instead of importing them from Google Fonts. Signed-off-by: Maggie Walker <[email protected]> Pull request: #603 Approved by: cwebberOps
Also modifies some of the styling for headings/paragraphs in Try Habitat to be more specific to that section, since the styles were being applied too globally. Signed-off-by: Maggie Walker <[email protected]> Pull request: #603 Approved by: cwebberOps
Signed-off-by: Maggie Walker <[email protected]> Pull request: #603 Approved by: cwebberOps
Signed-off-by: Maggie Walker <[email protected]> Pull request: #603 Approved by: cwebberOps
Also modifies the logic of the mobile nav slightly to support this new styling. Signed-off-by: Maggie Walker <[email protected]> Pull request: #603 Approved by: cwebberOps
Signed-off-by: Maggie Walker <[email protected]> Pull request: #603 Approved by: cwebberOps
Signed-off-by: Maggie Walker <[email protected]> Pull request: #603 Approved by: cwebberOps
Reflects new branding identity. Signed-off-by: Maggie Walker <[email protected]> Pull request: #603 Approved by: cwebberOps
Signed-off-by: Maggie Walker <[email protected]> Pull request: #603 Approved by: cwebberOps
Since this styling is only used in the footer cta, it is now only applied to that specific class. Signed-off-by: Maggie Walker <[email protected]> Pull request: #603 Approved by: cwebberOps
Signed-off-by: Maggie Walker <[email protected]> Pull request: #603 Approved by: cwebberOps
Also includes adding the fonts to our repo instead of hosting them on Google Fonts.