Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite README to be more developer-focused #613

Merged
merged 2 commits into from
Jun 2, 2016
Merged

Conversation

juliandunn
Copy link
Contributor

This PR rewrites the README to be more developer-oriented, i.e. for folks who are hacking on the code itself. We put a preamble in it to point users to the regular Habitat website and documentation.

I could use some help with what other links we feel we need to put in that preamble @davidwrede @ryankeairns.

Also, the Travis badge is broken because this isn't a public project yet. It will become a non-404 when we open it up.

@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @adamhjk, @nathenharvey, @smith, @fnichol and @reset to be potential reviewers

@bookshelfdave
Copy link
Contributor

I was just pairing with @jjasghar, and make test was taking quite awhile. Should we call out that it's not required to get a dev-shell going?

@juliandunn juliandunn force-pushed the jcd/readme-rewrite branch from a8c84eb to 6f45cf7 Compare June 1, 2016 21:50
@fnichol
Copy link
Collaborator

fnichol commented Jun 2, 2016

Yeah, that's probably a good point. Running a make or make build-all might even be more useful because you'd be left with the binary and service components ready to run, built from source.

@thesentinels
Copy link
Contributor

☔ The latest upstream changes (presumably 6b4f389) made this pull request unmergeable. Please resolve the merge conflicts.

@juliandunn juliandunn force-pushed the jcd/readme-rewrite branch from 6f45cf7 to 91024af Compare June 2, 2016 14:24
Julian C. Dunn added 2 commits June 2, 2016 10:42
@juliandunn juliandunn force-pushed the jcd/readme-rewrite branch from 91024af to 81094fd Compare June 2, 2016 14:42
@juliandunn
Copy link
Contributor Author

@thesentinels r+

@thesentinels
Copy link
Contributor

📌 Commit 81094fd has been approved by juliandunn

thesentinels pushed a commit that referenced this pull request Jun 2, 2016
Signed-off-by: Julian C. Dunn <[email protected]>

Pull request: #613
Approved by: juliandunn
@thesentinels
Copy link
Contributor

⌛ Testing commit 81094fd with merge 064a018...

thesentinels pushed a commit that referenced this pull request Jun 2, 2016
Signed-off-by: Julian C. Dunn <[email protected]>

Pull request: #613
Approved by: juliandunn
@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit 81094fd into master Jun 2, 2016
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Signed-off-by: Julian C. Dunn <[email protected]>

Pull request: #613
Approved by: juliandunn
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Signed-off-by: Julian C. Dunn <[email protected]>

Pull request: #613
Approved by: juliandunn
@smurawski smurawski deleted the jcd/readme-rewrite branch February 3, 2017 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants