Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a clear direction to the shared directory #614

Merged
merged 1 commit into from
Jun 1, 2016
Merged

Added a clear direction to the shared directory #614

merged 1 commit into from
Jun 1, 2016

Conversation

jjasghar
Copy link

@jjasghar jjasghar commented Jun 1, 2016

This adds a specific place for the shared directory in the tutorial.

@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @mattray, @cwebberOps, @davidwrede, @nathenharvey and @ryankeairns to be potential reviewers

@@ -18,7 +18,7 @@ To create a plan, do the following:

[2][default:/src/plans:0]# make new-plan plan=mytutorialapp

3. Open the `mytutorialapp/plan.sh` file in your favorite text editor. The filesystem is shared between your host machine and the studio, so you can use any text editor installed on your host machine, or use vim, which is installed in the studio environment. Here's an example of what the plan template creates:
3. Open the `mytutorialapp/plan.sh` file in your favorite text editor. The filesystem is shared between [`habitat/plans/mytutorialapp/`] your host machine and the studio, so you can use any text editor installed on your host machine, or use vim, which is installed in the studio environment. Here's an example of what the plan template creates:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean /src/plans/mytutorialapp?

I also have a rewrite that I'm going to submit as part of a PR. Let me know if you think it clears things up:

Open the mytutorialapp/plan.sh file on your host machine. The host filesystem is shared between your host machine and the studio, so you can use any text editor installed on your machine to edit your plan, and then use the studio to build your plan. The studio also contains vim, so if you want to edit plans within the studio, you can do that as well. Here's an example of what the plan template creates:

@jjasghar
Copy link
Author

jjasghar commented Jun 1, 2016

Dave Wrede Thanks JJ! I added a comment with my take on clearing things up. Let me know what you think.
JJ Asghar Ah i was trying to point out where the shared directory is, i had to find it in my text editor from the repo to plans/ then the tutorialapp directory
Dave Wrede ah, k

@davidwrede
Copy link

I'll merge this in now and then fold it into my broader rewrite later.

@davidwrede
Copy link

@thesentinels r+

@thesentinels
Copy link
Contributor

📌 Commit d5988a9 has been approved by davidwrede

@thesentinels
Copy link
Contributor

⌛ Testing commit d5988a9 with merge bbfe1de...

thesentinels pushed a commit that referenced this pull request Jun 1, 2016
Signed-off-by: JJ Asghar <[email protected]>

Pull request: #614
Approved by: davidwrede
@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit d5988a9 into habitat-sh:master Jun 1, 2016
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Signed-off-by: JJ Asghar <[email protected]>

Pull request: #614
Approved by: davidwrede
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants