Prettier error formatting upon error exit from supervisor #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kmacgugan <[email protected]>
| @@ -338,7 +338,7 @@ fn main() { | |||
| /// Exit with an error message and the right status code | |||
| #[allow(dead_code)] | |||
| fn exit_with(e: SupError, code: i32) { | |||
| println!("{:?}", e); | |||
| println!("{}", e.to_string()); | |||
There was a problem hiding this comment.
There's actually no need to alloc the SupError into a String here. Simply changing from {:?} to {} is the exact right thing to do 😄. The println! macro will take care of coercing whatever you pass it by calling the fmt::Display trait that SupError is implementing.
|
@kmacgugan thank you!
|
|
📌 Commit deb28e0 has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
Jun 2, 2016
Signed-off-by: kmacgugan <[email protected]> Pull request: #615 Approved by: reset
|
☀️ Test successful - travis |
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
Signed-off-by: kmacgugan <[email protected]> Pull request: #615 Approved by: reset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously supervisor errors looked like this:
SupError { err: HandlebarsTemplateFileError(TemplateError(UnexpectedClosingBraces(5, 44))), logkey: "ER", file: "src/error.rs", line: 300, column: 8 }
Now they look like this:
hab-sup(ER)[src/error.rs:288:8]: Cannot find a release of package in any sources: cargo/foo
Signed-off-by: kmacgugan [email protected]