Move OAuth code->token routines from SessionSrv to Builder-API #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `ExpiringSet` to dbcache crate. This is identical to the `BasicSet` except entities will expire from the set after an expiration time defined by a static trait function * `IndexSet` can now set the type of Key along with the type of the Value it stores at that key * Add GitHub -> Account directory lookup index to SessionSrv. This is used to map external IDs to our internal ID format * Fixes routing of SessionCreate messages. All messages will be routed by their external ID Signed-off-by: Jamie Winsor <[email protected]>
|
@habitat-sh/habitat-core-maintainers this is ready for review |
| Ok(Response::with((status::Ok, encoded))) | ||
| match github::authenticate(code) { | ||
| Ok(token) => { | ||
| match github::user(&token) { |
There was a problem hiding this comment.
The matchers are certainly doing nice work here
|
@reset Aside from one question above, this look great to me. I'm reasonably sure I understand the need for this now and agree that it's the right move. Good to merge! |
|
📌 Commit 09c0234 has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
Jun 2, 2016
* Add `ExpiringSet` to dbcache crate. This is identical to the `BasicSet` except entities will expire from the set after an expiration time defined by a static trait function * `IndexSet` can now set the type of Key along with the type of the Value it stores at that key * Add GitHub -> Account directory lookup index to SessionSrv. This is used to map external IDs to our internal ID format * Fixes routing of SessionCreate messages. All messages will be routed by their external ID Signed-off-by: Jamie Winsor <[email protected]> Pull request: #616 Approved by: reset
|
☀️ Test successful - travis |
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
* Add `ExpiringSet` to dbcache crate. This is identical to the `BasicSet` except entities will expire from the set after an expiration time defined by a static trait function * `IndexSet` can now set the type of Key along with the type of the Value it stores at that key * Add GitHub -> Account directory lookup index to SessionSrv. This is used to map external IDs to our internal ID format * Fixes routing of SessionCreate messages. All messages will be routed by their external ID Signed-off-by: Jamie Winsor <[email protected]> Pull request: #616 Approved by: reset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will move external user identification to the gateway service (Builder-API) from the session service (SessionSrv). We need to move external authentication here to know a) which SessionSrv to route messages to when we don't currently have a token and, b) to help with rate limiting authentication messages in case of an attack.
ExpiringSetto dbcache crate. This is identical to theBasicSetexcept entities willexpire from the set after an expiration time defined by a static trait function
IndexSetcan now set the type of Key along with the type of the Value it stores at that keyto our internal ID format
Signed-off-by: Jamie Winsor [email protected]