[studio] Add a hab user & group to default Studio type.
#618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change coupled with #617 should allow a user to enter a default Studio and immediately run: hab start core/redis without issues. Neither the Supervisor nor the `hab` CLI is responsible for adding users and/groups (at least at the moment) meaning that if a service package uses a non-privileged user to run under, this could result in a failure. Further work can be done to have the package announce its user requirements and have the Supervisor at least detect-and-fail is a user is not present (minimal solution) or attempt to add a user/group (a delightful solution). Signed-off-by: Fletcher Nichol <[email protected]>
|
By analyzing the blame information on this pull request, we identified @adamhjk to be a potential reviewer |
|
LGTM |
|
📌 Commit 60fd2ae has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
Jun 2, 2016
This change coupled with #617 should allow a user to enter a default Studio and immediately run: hab start core/redis without issues. Neither the Supervisor nor the `hab` CLI is responsible for adding users and/groups (at least at the moment) meaning that if a service package uses a non-privileged user to run under, this could result in a failure. Further work can be done to have the package announce its user requirements and have the Supervisor at least detect-and-fail is a user is not present (minimal solution) or attempt to add a user/group (a delightful solution). Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #618 Approved by: juliandunn
|
☀️ Test successful - travis |
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
This change coupled with #617 should allow a user to enter a default Studio and immediately run: hab start core/redis without issues. Neither the Supervisor nor the `hab` CLI is responsible for adding users and/groups (at least at the moment) meaning that if a service package uses a non-privileged user to run under, this could result in a failure. Further work can be done to have the package announce its user requirements and have the Supervisor at least detect-and-fail is a user is not present (minimal solution) or attempt to add a user/group (a delightful solution). Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #618 Approved by: juliandunn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change coupled with #617 should allow a user to enter a default
Studio and immediately run:
without issues.
Neither the Supervisor nor the
habCLI is responsible for adding usersand/groups (at least at the moment) meaning that if a service package
uses a non-privileged user to run under, this could result in a failure.
Further work can be done to have the package announce its user
requirements and have the Supervisor at least detect-and-fail is a user
is not present (minimal solution) or attempt to add a user/group (a
delightful solution).