Add experimental support for a statically built Supervisor, feature toggled in hab
#625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @adamhjk to be a potential reviewer |
fnichol
changed the title
habhab
fnichol
changed the title
habhab
|
Note that if/when we merge this, then I'll push a |
|
☔ The latest upstream changes (presumably d0cdaa8) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@fnichol this needs a rebase ;) |
Signed-off-by: Fletcher Nichol <[email protected]>
|
Cool I merge-conflicted my own self!
|
This change introduces a simple feature toggle which allows the `hab`
binary to use a statically build version of the Supervisor rather than
the current glibc dynamically linked version.
As this is the first feature toggle that I know of in the codebase,
we'll start really simple with an environment variable implementation
and think carefully about scaling up to more :)
To back the `hab start` and `hab sup` subcommands with the
`core/hab-sup-static` pacakge rather than the default `core/hab-sup`
package, set the `HAB_FEAT_SUP_STATIC` environment variable to a
non-empty value. Otherwise our default behavior continues as normal,
using the `core/hab-sup` package.
For example:
```
> env RUST_LOG=info,hab::command::sup=debug,hab::exec=debug HAB_FEAT_SUP_STATIC=true hab start core/redis
DEBUG:hab::command::sup: Enabling statically compiled Supervisor from core/hab-sup-static
DEBUG:hab::exec: Calling execv: ("/hab/pkgs/core/hab-sup-static/0.6.0/20160602141707/bin/hab-sup") ["start", "core/redis"]
hab-sup(MN): Starting core/redis
hab-sup(GS): Supervisor 172.17.0.2: 13d12e83-de28-4ff9-8674-a64af032952b
hab-sup(GS): Census redis.default: abf0c60c-1cae-40bc-b1a3-fc64d96a5193
hab-sup(GS): Starting inbound gossip listener
-- snip --
```
Signed-off-by: Fletcher Nichol <[email protected]>
fnichol
force-pushed
the
fnichol/hab-sup-static
branch
from
d7c421b to
2b95ce8
Compare
|
Let's take this - it's feature flagged off so we can roll it out whenever. |
|
📌 Commit 2b95ce8 has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
Jun 3, 2016
Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #625 Approved by: juliandunn
thesentinels
pushed a commit
that referenced
this pull request
Jun 3, 2016
This change introduces a simple feature toggle which allows the `hab`
binary to use a statically build version of the Supervisor rather than
the current glibc dynamically linked version.
As this is the first feature toggle that I know of in the codebase,
we'll start really simple with an environment variable implementation
and think carefully about scaling up to more :)
To back the `hab start` and `hab sup` subcommands with the
`core/hab-sup-static` pacakge rather than the default `core/hab-sup`
package, set the `HAB_FEAT_SUP_STATIC` environment variable to a
non-empty value. Otherwise our default behavior continues as normal,
using the `core/hab-sup` package.
For example:
```
> env RUST_LOG=info,hab::command::sup=debug,hab::exec=debug HAB_FEAT_SUP_STATIC=true hab start core/redis
DEBUG:hab::command::sup: Enabling statically compiled Supervisor from core/hab-sup-static
DEBUG:hab::exec: Calling execv: ("/hab/pkgs/core/hab-sup-static/0.6.0/20160602141707/bin/hab-sup") ["start", "core/redis"]
hab-sup(MN): Starting core/redis
hab-sup(GS): Supervisor 172.17.0.2: 13d12e83-de28-4ff9-8674-a64af032952b
hab-sup(GS): Census redis.default: abf0c60c-1cae-40bc-b1a3-fc64d96a5193
hab-sup(GS): Starting inbound gossip listener
-- snip --
```
Signed-off-by: Fletcher Nichol <[email protected]>
Pull request: #625
Approved by: juliandunn
|
☀️ Test successful - travis |
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #625 Approved by: juliandunn
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
This change introduces a simple feature toggle which allows the `hab`
binary to use a statically build version of the Supervisor rather than
the current glibc dynamically linked version.
As this is the first feature toggle that I know of in the codebase,
we'll start really simple with an environment variable implementation
and think carefully about scaling up to more :)
To back the `hab start` and `hab sup` subcommands with the
`core/hab-sup-static` pacakge rather than the default `core/hab-sup`
package, set the `HAB_FEAT_SUP_STATIC` environment variable to a
non-empty value. Otherwise our default behavior continues as normal,
using the `core/hab-sup` package.
For example:
```
> env RUST_LOG=info,hab::command::sup=debug,hab::exec=debug HAB_FEAT_SUP_STATIC=true hab start core/redis
DEBUG:hab::command::sup: Enabling statically compiled Supervisor from core/hab-sup-static
DEBUG:hab::exec: Calling execv: ("/hab/pkgs/core/hab-sup-static/0.6.0/20160602141707/bin/hab-sup") ["start", "core/redis"]
hab-sup(MN): Starting core/redis
hab-sup(GS): Supervisor 172.17.0.2: 13d12e83-de28-4ff9-8674-a64af032952b
hab-sup(GS): Census redis.default: abf0c60c-1cae-40bc-b1a3-fc64d96a5193
hab-sup(GS): Starting inbound gossip listener
-- snip --
```
Signed-off-by: Fletcher Nichol <[email protected]>
Pull request: #625
Approved by: juliandunn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set adds a statically build
hab-supPlan which produces acore/hab-sup-staticpackage. The defaults of using a glibc-based dynamically linked binary remain unchanged. This will allow us to begin a vetting of a static Supervisor approach without committing all users to the experiment.[hab] Add a simple feature toggle to use a static Supervisor.
This change introduces a simple feature toggle which allows the
habbinary to use a statically build version of the Supervisor rather than the current glibc dynamically linked version.As this is the first feature toggle that I know of in the codebase, we'll start really simple with an environment variable implementation and think carefully about scaling up to more :)
To back the
hab startandhab supsubcommands with thecore/hab-sup-staticpacakge rather than the defaultcore/hab-suppackage, set theHAB_FEAT_SUP_STATICenvironment variable to a non-empty value. Otherwise our default behavior continues as normal, using thecore/hab-suppackage.For example: