Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cryptography documentation added. #629

Merged
merged 3 commits into from
Jun 3, 2016
Merged

Cryptography documentation added. #629

merged 3 commits into from
Jun 3, 2016

Conversation

juliandunn
Copy link
Contributor

@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @cwebberOps and @ryankeairns to be potential reviewers

@davidwrede
Copy link

Copy looks good to me. Ready for @metadave sign off on the tech review.


Origin key cryptography is asymmetric; it has a public key that you can distribute freely, and a private key that you should keep safe.

Supervisors, by default, will refuse to run packages for which they do not have the public key. They use this public key to verify the integrity of the Habitat package they download, before running it. Supervisors can be provided the public key by pointing them at a depot that has it, or by putting the key on disk outside of Habitat.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"...or by putting the key on disk outside of Habitat." => do we want to call out /hab/cache/keys and HAB_CACHE_KEY_PATH?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a concepts document I'm leaving out the specifics; when we write the "jobs"-oriented documents we can put it in there.

@bookshelfdave
Copy link
Contributor

looks good

@davidwrede
Copy link

@thesentinels r+

@thesentinels
Copy link
Contributor

📌 Commit e38cb53 has been approved by davidwrede

thesentinels pushed a commit that referenced this pull request Jun 3, 2016
Pull request: #629
Approved by: davidwrede
thesentinels pushed a commit that referenced this pull request Jun 3, 2016
Pull request: #629
Approved by: davidwrede
thesentinels pushed a commit that referenced this pull request Jun 3, 2016
Pull request: #629
Approved by: davidwrede
@thesentinels
Copy link
Contributor

⌛ Testing commit e38cb53 with merge ca3eaee...

@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit e38cb53 into habitat-sh:master Jun 3, 2016
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Pull request: #629
Approved by: davidwrede
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Pull request: #629
Approved by: davidwrede
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Pull request: #629
Approved by: davidwrede
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants