-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pagination to listing packages #636
Conversation
@smith you'll need to hook up to the API additions for pagination but lexical sorting is done! |
39bb51a
to
919d38b
Compare
@@ -10,6 +10,7 @@ name = "bldr-api" | |||
doc = false | |||
|
|||
[dependencies] | |||
bodyparser = "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you even need bodyparser as a dep now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope! Just removed it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it needs to be removed from this line also :) as well as in the Cargo.lock.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, we need it in the builder-api for some of my work coming up this week anyway. I'll leave it here for now
Signed-off-by: Jamie Winsor <[email protected]>
@smith thanks for the review and testing this out for me! Great direction on how to create pagination in 2016 😄 |
📌 Commit 55a38fa has been approved by |
Signed-off-by: Jamie Winsor <[email protected]> Pull request: #636 Approved by: reset
In order for this to work in a browser, we need to add |
☀️ Test successful - travis |
Signed-off-by: Jamie Winsor <[email protected]> Pull request: #636 Approved by: reset
Range
header to list the next portion of a long list of objectsSigned-off-by: Jamie Winsor [email protected]