Add additional configurable options for builder-api server #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added `github.client_id` as a configurable field to builder-api server * Added `github.client_secret` as a configurable field to builder-api server * Added `github.url` as a configurable field to builder-api server * All OAuth calls will now use the values of these fields Signed-off-by: Jamie Winsor <[email protected]>
|
By analyzing the blame information on this pull request, we identified @adamhjk to be a potential reviewer |
|
@smith this is the business you need to be able to configure the app to talk to Github using other credentials than the ones I generated ;) |
|
It works!
|
|
📌 Commit 68aab7a has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
Jun 3, 2016
* Added `github.client_id` as a configurable field to builder-api server * Added `github.client_secret` as a configurable field to builder-api server * Added `github.url` as a configurable field to builder-api server * All OAuth calls will now use the values of these fields Signed-off-by: Jamie Winsor <[email protected]> Pull request: #637 Approved by: smith
|
☀️ Test successful - travis |
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
* Added `github.client_id` as a configurable field to builder-api server * Added `github.client_secret` as a configurable field to builder-api server * Added `github.url` as a configurable field to builder-api server * All OAuth calls will now use the values of these fields Signed-off-by: Jamie Winsor <[email protected]> Pull request: #637 Approved by: smith
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github.client_idas a configurable field to builder-api servergithub.client_secretas a configurable field to builder-api servergithub.urlas a configurable field to builder-api serverSigned-off-by: Jamie Winsor [email protected]