Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage edits, Update sidebar layout content/styles, and Add community page #642

Merged
merged 14 commits into from
Jun 3, 2016

Conversation

magwalk
Copy link
Contributor

@magwalk magwalk commented Jun 3, 2016

Sidebar layout screenshot:
screen shot 2016-06-03 at 10 59 46 am

Community page screenshot:
screen shot 2016-06-03 at 11 37 07 am

magwalk added 13 commits June 3, 2016 11:34
Signed-off-by: Maggie Walker <[email protected]>
Signed-off-by: Maggie Walker <[email protected]>
Signed-off-by: Maggie Walker <[email protected]>
So it doesn't cause a horizontal scroll when the screen size
gets smaller than the graphic size.

Signed-off-by: Maggie Walker <[email protected]>
Also modifies the existing nav_class helper to become a broader
layout_class helper, so it can be used on the body as well as
the nav.

Signed-off-by: Maggie Walker <[email protected]>
Signed-off-by: Maggie Walker <[email protected]>
Signed-off-by: Maggie Walker <[email protected]>
@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @cwebberOps, @ryankeairns and @juliandunn to be potential reviewers

@reset
Copy link
Collaborator

reset commented Jun 3, 2016

gif-keyboard-8774087021766238149

@magwalk
Copy link
Contributor Author

magwalk commented Jun 3, 2016

Previous commit is to remove footer CTA on all sidebar pages.
screen shot 2016-06-03 at 11 58 13 am

@cwebberOps
Copy link
Contributor

@thesentinels r+

@thesentinels
Copy link
Contributor

📌 Commit c502831 has been approved by cwebberOps

@thesentinels
Copy link
Contributor

⌛ Testing commit c502831 with merge e6357d6...

thesentinels pushed a commit that referenced this pull request Jun 3, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #642
Approved by: cwebberOps
thesentinels pushed a commit that referenced this pull request Jun 3, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #642
Approved by: cwebberOps
thesentinels pushed a commit that referenced this pull request Jun 3, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #642
Approved by: cwebberOps
thesentinels pushed a commit that referenced this pull request Jun 3, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #642
Approved by: cwebberOps
thesentinels pushed a commit that referenced this pull request Jun 3, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #642
Approved by: cwebberOps
thesentinels pushed a commit that referenced this pull request Jun 3, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #642
Approved by: cwebberOps
thesentinels pushed a commit that referenced this pull request Jun 3, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #642
Approved by: cwebberOps
thesentinels pushed a commit that referenced this pull request Jun 3, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #642
Approved by: cwebberOps
thesentinels pushed a commit that referenced this pull request Jun 3, 2016
So it doesn't cause a horizontal scroll when the screen size
gets smaller than the graphic size.

Signed-off-by: Maggie Walker <[email protected]>

Pull request: #642
Approved by: cwebberOps
thesentinels pushed a commit that referenced this pull request Jun 3, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #642
Approved by: cwebberOps
thesentinels pushed a commit that referenced this pull request Jun 3, 2016
Also modifies the existing nav_class helper to become a broader
layout_class helper, so it can be used on the body as well as
the nav.

Signed-off-by: Maggie Walker <[email protected]>

Pull request: #642
Approved by: cwebberOps
thesentinels pushed a commit that referenced this pull request Jun 3, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #642
Approved by: cwebberOps
thesentinels pushed a commit that referenced this pull request Jun 3, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #642
Approved by: cwebberOps
thesentinels pushed a commit that referenced this pull request Jun 3, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #642
Approved by: cwebberOps
@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit c502831 into master Jun 3, 2016
@fnichol fnichol deleted the mwalker/redesign branch June 3, 2016 21:33
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #642
Approved by: cwebberOps
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #642
Approved by: cwebberOps
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #642
Approved by: cwebberOps
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #642
Approved by: cwebberOps
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #642
Approved by: cwebberOps
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #642
Approved by: cwebberOps
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #642
Approved by: cwebberOps
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #642
Approved by: cwebberOps
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
So it doesn't cause a horizontal scroll when the screen size
gets smaller than the graphic size.

Signed-off-by: Maggie Walker <[email protected]>

Pull request: #642
Approved by: cwebberOps
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #642
Approved by: cwebberOps
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Also modifies the existing nav_class helper to become a broader
layout_class helper, so it can be used on the body as well as
the nav.

Signed-off-by: Maggie Walker <[email protected]>

Pull request: #642
Approved by: cwebberOps
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #642
Approved by: cwebberOps
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #642
Approved by: cwebberOps
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Signed-off-by: Maggie Walker <[email protected]>

Pull request: #642
Approved by: cwebberOps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants