Implement searching in the web app #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* There's a search box in package list pages that will search if you type in it. * Going to /pkgs/search/:query also does what you would expect. * Fix the bug related to the new range header stuff that was stopping single package pages from displaying. * Fix the bug where my math about pagination was slightly off because of a `<=` rather than a `<`. * When no packages are found, it now says "No packages found" instead of "Failed to load packages." *IMPORTANT NOTE*: Packages that are on an existing depot *will not* show up in search results unless the are re-uploaded or somehow redis gets told to index them. Signed-off-by: Nathan L Smith <[email protected]>
|
By analyzing the blame information on this pull request, we identified @ryankeairns and @fnichol to be potential reviewers |
|
📌 Commit b690ba0 has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
Jun 6, 2016
* There's a search box in package list pages that will search if you type in it. * Going to /pkgs/search/:query also does what you would expect. * Fix the bug related to the new range header stuff that was stopping single package pages from displaying. * Fix the bug where my math about pagination was slightly off because of a `<=` rather than a `<`. * When no packages are found, it now says "No packages found" instead of "Failed to load packages." *IMPORTANT NOTE*: Packages that are on an existing depot *will not* show up in search results unless the are re-uploaded or somehow redis gets told to index them. Signed-off-by: Nathan L Smith <[email protected]> Pull request: #657 Approved by: reset
|
☀️ Test successful - travis |
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
* There's a search box in package list pages that will search if you type in it. * Going to /pkgs/search/:query also does what you would expect. * Fix the bug related to the new range header stuff that was stopping single package pages from displaying. * Fix the bug where my math about pagination was slightly off because of a `<=` rather than a `<`. * When no packages are found, it now says "No packages found" instead of "Failed to load packages." *IMPORTANT NOTE*: Packages that are on an existing depot *will not* show up in search results unless the are re-uploaded or somehow redis gets told to index them. Signed-off-by: Nathan L Smith <[email protected]> Pull request: #657 Approved by: reset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in it.
single package pages from displaying.
<=rather than a<.of "Failed to load packages."
IMPORTANT NOTE: Packages that are on an existing depot will not show
up in search results unless the are re-uploaded or somehow redis gets
told to index them.