Use cookies instead of sessionStorage for sessions #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sessionStorage doesn't persist between browser windows, but cookies behave like one would expect. Change the GitHub session storage to use cookies instead. Signed-off-by: Nathan L Smith <[email protected]>
|
📌 Commit 3cc9074 has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
Jun 7, 2016
sessionStorage doesn't persist between browser windows, but cookies behave like one would expect. Change the GitHub session storage to use cookies instead. Signed-off-by: Nathan L Smith <[email protected]> Pull request: #660 Approved by: reset
|
☀️ Test successful - travis |
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
sessionStorage doesn't persist between browser windows, but cookies behave like one would expect. Change the GitHub session storage to use cookies instead. Signed-off-by: Nathan L Smith <[email protected]> Pull request: #660 Approved by: reset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sessionStorage doesn't persist between browser windows, but cookies
behave like one would expect. Change the GitHub session storage to use
cookies instead.