Begin adding origin key management #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make it so you can go to /origins/x to view that origin (doesn't check for existence or permissions yet) * Very basic validation of key pasting (but you can't save yet) * Remove some logic around "default origin" that's not being used * Fix test runner to use correct loader Signed-off-by: Nathan L Smith <[email protected]>
|
By analyzing the blame information on this pull request, we identified @ryankeairns and @fnichol to be potential reviewers |
|
📌 Commit 41d9e24 has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
Jun 8, 2016
* Make it so you can go to /origins/x to view that origin (doesn't check for existence or permissions yet) * Very basic validation of key pasting (but you can't save yet) * Remove some logic around "default origin" that's not being used * Fix test runner to use correct loader Signed-off-by: Nathan L Smith <[email protected]> Pull request: #674 Approved by: reset
|
☀️ Test successful - travis |
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
* Make it so you can go to /origins/x to view that origin (doesn't check for existence or permissions yet) * Very basic validation of key pasting (but you can't save yet) * Remove some logic around "default origin" that's not being used * Fix test runner to use correct loader Signed-off-by: Nathan L Smith <[email protected]> Pull request: #674 Approved by: reset
stevendanna
added a commit
to stevendanna/habitat
that referenced
this pull request
Oct 23, 2019
Previously, the gateway state had no health check information for a
given service until the first health-check. This resulted in a 404 for
the `/services/SERVICE_NAME/SERVICE_GROUP/health` endpoint. However,
according to the documentation, a 404 response code means the service
isn't loaded:
```
/{name}/{group}/health:
get:
description: Health check status and output for the given service group
responses:
200:
description: Health Check - Ok / Warning
body:
application/json:
type: healthCheckOutput
404:
description: Service not loaded
500:
description: Health Check - Unknown
503:
description: Health Check - Critical
```
This change avoids the problem by populating the gateway state with
Unknown when we start the health checks. As a result we now return 500
for the health endpoint of a loaded service until the first
health-check comes back, in accordance with the API documentation.
Fixes habitat-sh#674
Signed-off-by: Steven Danna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for existence or permissions yet)