Align web app UI to website design #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 7, 2016 15:23
Signed-off-by: Ryan Keairns <[email protected]>
Signed-off-by: Ryan Keairns <[email protected]>
| </footer> | ||
| </div>`, | ||
| </div> | ||
| <footer class="main-footer"> |
There was a problem hiding this comment.
The footer is big enough now that it should be broken into its own component.
|
This is beautiful. A few things need fixing:
|
| </ul> | ||
| <div class="main-nav--container clearfix"> | ||
| <div class="main-nav--logo"> | ||
| <a href="/"><h1>{{appName}}</h1></a> |
There was a problem hiding this comment.
There's inconsistent use of 2/4 spaces in here.
|
📌 Commit 8edc7d6 has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
Jun 8, 2016
Signed-off-by: Ryan Keairns <[email protected]> Pull request: #679 Approved by: smith
thesentinels
pushed a commit
that referenced
this pull request
Jun 8, 2016
Signed-off-by: Ryan Keairns <[email protected]> Pull request: #679 Approved by: smith
|
☀️ Test successful - travis |
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
Signed-off-by: Ryan Keairns <[email protected]> Pull request: #679 Approved by: smith
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
Signed-off-by: Ryan Keairns <[email protected]> Pull request: #679 Approved by: smith
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The big additions/changes are the nav/global navigation and footer to match the new website design (including smaller device size support... although there will be more work to refine this, it is functional).
There are many additional smaller tweaks related to global layout and branding.