Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add friends_only feature flag #680

Merged
merged 1 commit into from
Jun 9, 2016
Merged

Add friends_only feature flag #680

merged 1 commit into from
Jun 9, 2016

Conversation

smith
Copy link
Contributor

@smith smith commented Jun 8, 2016

Make it so setting friends_only = false will turn off the
friends.habitat.sh checking.

gif-keyboard-9115676299696095521

Make it so setting `friends_only = false` will turn off the
friends.habitat.sh checking.

Signed-off-by: Nathan L Smith <[email protected]>
@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @fnichol, @jtimberman and @adamhjk to be potential reviewers

@bookshelfdave
Copy link
Contributor

@thesentinels r+

@thesentinels
Copy link
Contributor

📌 Commit ff6e410 has been approved by metadave

@thesentinels
Copy link
Contributor

⌛ Testing commit ff6e410 with merge 539a2a6...

thesentinels pushed a commit that referenced this pull request Jun 9, 2016
Make it so setting `friends_only = false` will turn off the
friends.habitat.sh checking.

Signed-off-by: Nathan L Smith <[email protected]>

Pull request: #680
Approved by: metadave
@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit ff6e410 into master Jun 9, 2016
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Make it so setting `friends_only = false` will turn off the
friends.habitat.sh checking.

Signed-off-by: Nathan L Smith <[email protected]>

Pull request: #680
Approved by: metadave
@smith smith deleted the nls/friends-only branch July 25, 2016 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants