Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hab] Add hab pkg export subcommand #692

Merged
merged 1 commit into from
Jun 9, 2016
Merged

[hab] Add hab pkg export subcommand #692

merged 1 commit into from
Jun 9, 2016

Conversation

seth
Copy link

@seth seth commented Jun 9, 2016

The hab pkg export FORMAT PKG_IDENT subcommand exports a pkg in the
specified format. Currently docker and aci are the only two supported
formats. The coresponding core packages will be installed on demand if
required (core/hab-pkg-dockerize and core/hab-pkg-aci).

@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @fnichol, @metadave and @adamhjk to be potential reviewers

)
)
)
(@subcommand export =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would this make more sense as a hab artifact subcommand? ping @fnichol

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we decided that users would get confused by pkg versus artifact so actually, hab artifact upload should get changed to hab pkg upload

@reset
Copy link
Collaborator

reset commented Jun 9, 2016

gif-keyboard-8941594285546027858

@seth nice to see your first contribution! :)

The `hab pkg export FORMAT PKG_IDENT` subcommand exports a pkg in the
specified format. Currently docker and aci are the only two supported
formats. The coresponding core packages will be installed on demand if
required (core/hab-pkg-dockerize and core/hab-pkg-aci).
@reset
Copy link
Collaborator

reset commented Jun 9, 2016

@seth looks great!

gif-keyboard-16439025676453200325

@thesentinels r+

@thesentinels
Copy link
Contributor

📌 Commit 7126aca has been approved by reset

thesentinels pushed a commit that referenced this pull request Jun 9, 2016
The `hab pkg export FORMAT PKG_IDENT` subcommand exports a pkg in the
specified format. Currently docker and aci are the only two supported
formats. The coresponding core packages will be installed on demand if
required (core/hab-pkg-dockerize and core/hab-pkg-aci).

Pull request: #692
Approved by: reset
@thesentinels
Copy link
Contributor

⌛ Testing commit 7126aca with merge 97f147f...

@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit 7126aca into habitat-sh:master Jun 9, 2016
thesentinels pushed a commit that referenced this pull request Jun 10, 2016
Signed-off-by: Julian C. Dunn <[email protected]>

Pull request: #713
Approved by: davidwrede
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
The `hab pkg export FORMAT PKG_IDENT` subcommand exports a pkg in the
specified format. Currently docker and aci are the only two supported
formats. The coresponding core packages will be installed on demand if
required (core/hab-pkg-dockerize and core/hab-pkg-aci).

Pull request: #692
Approved by: reset
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Signed-off-by: Julian C. Dunn <[email protected]>

Pull request: #713
Approved by: davidwrede
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants