Fix missing app module #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`npm run dist` was running `npm run clean-js` which deletes app/**.js, but recently we added a couple .js files and we were deleting them when we built that app so that wasn't cool. Signed-off-by: Nathan L Smith <[email protected]>
|
By analyzing the blame information on this pull request, we identified @fnichol and @jtimberman to be potential reviewers |
|
📌 Commit 872c9d6 has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
Jun 9, 2016
`npm run dist` was running `npm run clean-js` which deletes app/**.js, but recently we added a couple .js files and we were deleting them when we built that app so that wasn't cool. Signed-off-by: Nathan L Smith <[email protected]> Pull request: #696 Approved by: metadave
|
☀️ Test successful - travis |
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
`npm run dist` was running `npm run clean-js` which deletes app/**.js, but recently we added a couple .js files and we were deleting them when we built that app so that wasn't cool. Signed-off-by: Nathan L Smith <[email protected]> Pull request: #696 Approved by: metadave
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run distwas runningnpm run clean-jswhich deletes app/**.js,but recently we added a couple .js files and we were deleting them when
we built that app so that wasn't cool.