refactor Sidecar into an actor #71
Conversation
health check hook can now be templatized with mustache
|
We may want to push updated data into the sidecar in the main loop instead of aquiring a read lock on the package/service_config from within the sidecar. This will increase throughput for the HTTP interface and stop clients from there from aquiring a massive amoutn of read locks. This should be fine for now.
|
|
This PR has passed 'Verify' and is ready for review and approval! |
| if worker.census.needs_write { | ||
| let census_toml = try!(worker.census.to_toml()); | ||
| worker.service_config.census(census_toml); | ||
| let mut service_config = worker.service_config.write().unwrap(); |
There was a problem hiding this comment.
This isn't ideal, either. The blocks below send calls to multiple actors below which is a form of "polling". We instead want to be notified of changes and only obtain a lock when we need to.
|
Nice work! |
|
@delivery approve |
Merged change 6a7f2591-3666-45e6-acf1-846ada5e20c9 From review branch sidecar-refactor into master Signed-off-by: adam <[email protected]>
|
Change: 6a7f2591-3666-45e6-acf1-846ada5e20c9 approved by: @adamhjk |
health check hook can now be templatized with mustache