[depot-client] Use HTTP/201 as success for artifact & key upload. #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fletcher Nichol <[email protected]>
Signed-off-by: Fletcher Nichol <[email protected]>
|
looks good! |
| @@ -218,8 +218,8 @@ fn sub_artifact_upload(m: &ArgMatches) -> Result<()> { | |||
| Ok(token) => token, | |||
| Err(_) => { | |||
| return Err(Error::ArgumentError("Missing authentication token - Set \ | |||
| AUTH_TOKEN env var or specify a value for \ | |||
| --auth-token and try again.")) | |||
| HAB_AUTH_TOKEN env var or specify a value \ | |||
There was a problem hiding this comment.
I was the first user to be burned by trying both of these :) It's all cool, we great now
|
Confirmed previous upload behavior: |
|
Using @metadave's comment as my +1, thanks! |
|
📌 Commit f4f08aa has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
Jun 10, 2016
Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #714 Approved by: fnichol
thesentinels
pushed a commit
that referenced
this pull request
Jun 10, 2016
Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #714 Approved by: fnichol
|
☀️ Test successful - travis |
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #714 Approved by: fnichol
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #714 Approved by: fnichol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.