fix Try Habitat on mobile #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 10, 2016 10:29
Signed-off-by: Ryan Keairns <[email protected]>
Signed-off-by: Ryan Keairns <[email protected]>
|
By analyzing the blame information on this pull request, we identified @cwebberOps, @magwalk, @juliandunn and @thommay to be potential reviewers |
| @@ -54,7 +54,7 @@ $main-nav-breakpoint: 710px; | |||
| } | |||
|
|
|||
| .main-nav--logo { | |||
| @include grid-column(4); | |||
| @include grid-column(3); | |||
|
|
|||
There was a problem hiding this comment.
This fixes some mobile nav styling issues where the button and links wrapped to second line.
| @@ -84,10 +93,12 @@ code { | |||
|
|
|||
| a.active { | |||
| background-color: $hab-blue !important; | |||
| color: $white; | |||
| } | |||
There was a problem hiding this comment.
Somewhere along the way, the button text changed from gray to white - this overrides it to white for more contrast/readability.
|
📌 Commit e047632 has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
Jun 10, 2016
Signed-off-by: Ryan Keairns <[email protected]> Pull request: #716 Approved by: smith
thesentinels
pushed a commit
that referenced
this pull request
Jun 10, 2016
Signed-off-by: Ryan Keairns <[email protected]> Pull request: #716 Approved by: smith
|
☀️ Test successful - travis |
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
Signed-off-by: Ryan Keairns <[email protected]> Pull request: #716 Approved by: smith
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
Signed-off-by: Ryan Keairns <[email protected]> Pull request: #716 Approved by: smith
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered last night that I could not bring up the keyboard on my iPhone while on Try Habitat.
Research indicated that only true inputs will trigger the iOS keyboard, so this PR adds a transparent input. I tested it on the xcode iOS simulator for iPhone 5/6 and iPad Air 2 and it works, but we'll see what happens in the wild :)
I've also changed the Next button to look disabled but not actually be disabled since the current javascript we're using does not properly enable the button on mobile Safari.
Signed-off-by: Ryan Keairns [email protected]