Initial draft of file upload topic #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwrede
commented
Jun 10, 2016
davidwrede
commented
- File upload topic
- Left nav changes
- Formatting fixes in security topic
- Removed typo from println output in gossip_file.rs
|
By analyzing the blame information on this pull request, we identified @juliandunn, @metadave, @TrevorBramble and @fnichol to be potential reviewers |
|
@metadave can you review the content + code fix? |
| @@ -404,7 +404,7 @@ impl GossipFileList { | |||
| let next_retries = fwr.total_retries + 1; | |||
| let exp_backoff_seconds = 2i64.pow(next_retries); | |||
| let next = SteadyTime::now() + Duration::seconds(exp_backoff_seconds); | |||
| println!("Retrying write to l{} in {} seconds", | |||
| println!("Retrying write to {} in {} seconds", | |||
added 5 commits
June 11, 2016 14:59
Signed-off-by: David Wrede <[email protected]>
Signed-off-by: David Wrede <[email protected]>
Signed-off-by: David Wrede <[email protected]>
Signed-off-by: David Wrede <[email protected]>
Signed-off-by: David Wrede <[email protected]>
|
📌 Commit b05f1b0 has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
Jun 11, 2016
Signed-off-by: David Wrede <[email protected]> Pull request: #717 Approved by: davidwrede
thesentinels
pushed a commit
that referenced
this pull request
Jun 11, 2016
Signed-off-by: David Wrede <[email protected]> Pull request: #717 Approved by: davidwrede
thesentinels
pushed a commit
that referenced
this pull request
Jun 11, 2016
Signed-off-by: David Wrede <[email protected]> Pull request: #717 Approved by: davidwrede
thesentinels
pushed a commit
that referenced
this pull request
Jun 11, 2016
Signed-off-by: David Wrede <[email protected]> Pull request: #717 Approved by: davidwrede
thesentinels
pushed a commit
that referenced
this pull request
Jun 11, 2016
Signed-off-by: David Wrede <[email protected]> Pull request: #717 Approved by: davidwrede
|
☀️ Test successful - travis |
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
Signed-off-by: David Wrede <[email protected]> Pull request: #717 Approved by: davidwrede
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
Signed-off-by: David Wrede <[email protected]> Pull request: #717 Approved by: davidwrede
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
Signed-off-by: David Wrede <[email protected]> Pull request: #717 Approved by: davidwrede
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
Signed-off-by: David Wrede <[email protected]> Pull request: #717 Approved by: davidwrede
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
Signed-off-by: David Wrede <[email protected]> Pull request: #717 Approved by: davidwrede
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.