Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch 'Maintainers' to 'Contributors' in plans #720

Merged
merged 1 commit into from
Jun 14, 2016
Merged

Switch 'Maintainers' to 'Contributors' in plans #720

merged 1 commit into from
Jun 14, 2016

Conversation

nathenharvey
Copy link

This helps distinguish those who have commit access to the code repository (maintainers) and those who have committed code to the project (contributors).

Signed-off-by: Nathen Harvey [email protected]

@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @fnichol, @metadave, @adamhjk, @reset and @jtimberman to be potential reviewers

@adamhjk
Copy link
Contributor

adamhjk commented Jun 10, 2016

One thing that's going to be different in Habitat - Maintainers will have r+ in homu, but they probably won't have admin rights to the github repo itself. I don't think that matters for this commit.

@thesentinels
Copy link
Contributor

☔ The latest upstream changes (presumably 8b161b1) made this pull request unmergeable. Please resolve the merge conflicts.

@bookshelfdave
Copy link
Contributor

we're waiting until this evening to merge this PR

This helps distinguish those who have commit access to the code repository (maintainers) and those who have committed code to the project (contributors).

Signed-off-by: Nathen Harvey <[email protected]>
@smith
Copy link
Contributor

smith commented Jun 14, 2016

@thesentinels r+

@thesentinels
Copy link
Contributor

📌 Commit 67cd40a has been approved by smith

@thesentinels
Copy link
Contributor

⌛ Testing commit 67cd40a with merge 957a676...

thesentinels pushed a commit that referenced this pull request Jun 14, 2016
This helps distinguish those who have commit access to the code repository (maintainers) and those who have committed code to the project (contributors).

Signed-off-by: Nathen Harvey <[email protected]>

Pull request: #720
Approved by: smith
@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit 67cd40a into habitat-sh:master Jun 14, 2016
@nathenharvey nathenharvey deleted the nathen/rename_habitat_maintainers branch June 14, 2016 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants