Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web app package output styles and footer fix #721

Merged
merged 1 commit into from
Jun 10, 2016

Conversation

ryankeairns
Copy link
Contributor

@ryankeairns ryankeairns commented Jun 10, 2016

This styles up the package out including the manifest and fixes the footer.

Package output
screenshot 2016-06-10 13 08 30

Footer design
screenshot 2016-06-10 13 08 39

Signed-off-by: Ryan Keairns [email protected]

@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @smith and @fnichol to be potential reviewers

&.has-sidebar {
@include outer-container;
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to put the deps on the side for easier access.

@smith
Copy link
Contributor

smith commented Jun 10, 2016

Looks great!

@thesentinels r+

Uploading gif-keyboard-15326036104627558525.gif…

@thesentinels
Copy link
Contributor

📌 Commit acd956a has been approved by smith

@thesentinels
Copy link
Contributor

⌛ Testing commit acd956a with merge 4c684c3...

thesentinels pushed a commit that referenced this pull request Jun 10, 2016
Signed-off-by: Ryan Keairns <[email protected]>

Pull request: #721
Approved by: smith
@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit acd956a into master Jun 10, 2016
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Signed-off-by: Ryan Keairns <[email protected]>

Pull request: #721
Approved by: smith
@smurawski smurawski deleted the rk/webapp-stylings branch February 3, 2017 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants