Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display https URL in trial output #733

Merged
merged 1 commit into from
Jun 11, 2016
Merged

Display https URL in trial output #733

merged 1 commit into from
Jun 11, 2016

Conversation

seth
Copy link

@seth seth commented Jun 11, 2016

No description provided.

@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @ryankeairns and @juliandunn to be potential reviewers

@juliandunn
Copy link
Contributor

@seth Can you also remove the port :9632 from the output, because in production we'll be running on 443 by default.

@seth
Copy link
Author

seth commented Jun 11, 2016

@juliandunn updated

@juliandunn
Copy link
Contributor

lgtm, thanks!

@thesentinels r+

@thesentinels
Copy link
Contributor

📌 Commit 086ef5d has been approved by juliandunn

@thesentinels
Copy link
Contributor

⌛ Testing commit 086ef5d with merge c4f031f...

thesentinels pushed a commit that referenced this pull request Jun 11, 2016
Pull request: #733
Approved by: juliandunn
@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit 086ef5d into habitat-sh:master Jun 11, 2016
@juliandunn juliandunn deleted the sf/https-for-trial-output branch June 11, 2016 05:52
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Pull request: #733
Approved by: juliandunn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants