[core] Return Err in PackageInstall::load when pkg path not present.
#741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking for the `/hab/pkgs` directory hasn't been a concern until we started producing a portable `hab` CLI binary which doesn't necessarily run inside a Habitat package itself. The package install detection logic was initially running under the assumption that it was a Supervisor and hence properly installed as a Habitat package. Then our glibc/dynamic version of `hab` had the same set of assumptions (i.e. that it was running in a Habitat package, hence the parent directories would exist). This fix performs an early return if the package root path does not exist which is accurate: no Habitat packages will exist so there's no more detection work to do! Closes #736 Signed-off-by: Fletcher Nichol <[email protected]>
|
By analyzing the blame information on this pull request, we identified @reset to be a potential reviewer |
|
A repro is possible in the devshell, but you must delete the package root directory to trigger the failure: And after: |
|
Confirmed with a release-style build: |
|
📌 Commit 8e09428 has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
Jun 11, 2016
Checking for the `/hab/pkgs` directory hasn't been a concern until we started producing a portable `hab` CLI binary which doesn't necessarily run inside a Habitat package itself. The package install detection logic was initially running under the assumption that it was a Supervisor and hence properly installed as a Habitat package. Then our glibc/dynamic version of `hab` had the same set of assumptions (i.e. that it was running in a Habitat package, hence the parent directories would exist). This fix performs an early return if the package root path does not exist which is accurate: no Habitat packages will exist so there's no more detection work to do! Closes #736 Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #741 Approved by: fnichol
|
☀️ Test successful - travis |
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
Checking for the `/hab/pkgs` directory hasn't been a concern until we started producing a portable `hab` CLI binary which doesn't necessarily run inside a Habitat package itself. The package install detection logic was initially running under the assumption that it was a Supervisor and hence properly installed as a Habitat package. Then our glibc/dynamic version of `hab` had the same set of assumptions (i.e. that it was running in a Habitat package, hence the parent directories would exist). This fix performs an early return if the package root path does not exist which is accurate: no Habitat packages will exist so there's no more detection work to do! Closes #736 Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #741 Approved by: fnichol
raskchanky
pushed a commit
that referenced
this pull request
Apr 16, 2019
Checking for the `/hab/pkgs` directory hasn't been a concern until we started producing a portable `hab` CLI binary which doesn't necessarily run inside a Habitat package itself. The package install detection logic was initially running under the assumption that it was a Supervisor and hence properly installed as a Habitat package. Then our glibc/dynamic version of `hab` had the same set of assumptions (i.e. that it was running in a Habitat package, hence the parent directories would exist). This fix performs an early return if the package root path does not exist which is accurate: no Habitat packages will exist so there's no more detection work to do! Closes #736 Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #741 Approved by: fnichol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking for the
/hab/pkgsdirectory hasn't been a concern until westarted producing a portable
habCLI binary which doesn't necessarilyrun inside a Habitat package itself. The package install detection logic
was initially running under the assumption that it was a Supervisor and
hence properly installed as a Habitat package. Then our glibc/dynamic
version of
habhad the same set of assumptions (i.e. that it wasrunning in a Habitat package, hence the parent directories would exist).
This fix performs an early return if the package root path does not
exist which is accurate: no Habitat packages will exist so there's no
more detection work to do!
Closes #736