Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plans/ruby-rails-sample] Use handlebars in config #748

Merged
merged 1 commit into from
Jun 11, 2016

Conversation

jtimberman
Copy link
Contributor

We need to update the database.yml template to use handlebars syntax
instead of mustache.

Signed-off-by: jtimberman [email protected]

We need to update the database.yml template to use handlebars syntax
instead of mustache.

Signed-off-by: jtimberman <[email protected]>
@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @juliandunn to be a potential reviewer

@adamhjk
Copy link
Contributor

adamhjk commented Jun 11, 2016

gif-keyboard-14459780969214574728

@adamhjk
Copy link
Contributor

adamhjk commented Jun 11, 2016

@thesentinels r+

@thesentinels
Copy link
Contributor

📌 Commit 718dca1 has been approved by adamhjk

@thesentinels
Copy link
Contributor

⌛ Testing commit 718dca1 with merge 86d1ead...

thesentinels pushed a commit that referenced this pull request Jun 11, 2016
We need to update the database.yml template to use handlebars syntax
instead of mustache.

Signed-off-by: jtimberman <[email protected]>

Pull request: #748
Approved by: adamhjk
@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit 718dca1 into master Jun 11, 2016
@jtimberman jtimberman deleted the jtimberman/rails-with-handlebars branch June 12, 2016 02:38
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
We need to update the database.yml template to use handlebars syntax
instead of mustache.

Signed-off-by: jtimberman <[email protected]>

Pull request: #748
Approved by: adamhjk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants