Rebuild all Habitat packages, because fun. #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fletcher Nichol <[email protected]>
Signed-off-by: Fletcher Nichol <[email protected]>
This is a change from former behavior when `hab` was used to only install package dependencies. Now it is used in every run to hash all the files and to sign that `FILES` metadata, and to sign the resulting package artifact. Consequently, the `$NO_INSTALL_DEPS` environment variable is used in the `_install_dependency()` function to decide whether or not to install external packages. Signed-off-by: Fletcher Nichol <[email protected]>
|
|
Signed-off-by: Fletcher Nichol <[email protected]>
Signed-off-by: Fletcher Nichol <[email protected]>
Signed-off-by: Fletcher Nichol <[email protected]>
This is not a full solution, but this plan will no longer build if it takes a dependency on `core/hab-bpm`. A later change will restore the hooks to use template data vs. a shell out to the filesystem. Signed-off-by: Fletcher Nichol <[email protected]>
Signed-off-by: Fletcher Nichol <[email protected]>
Signed-off-by: Fletcher Nichol <[email protected]>
fnichol
changed the title
|
@habitat-sh/habitat-core-maintainers This PR is now ready for a review and merge. I was able to confirm the fixes work as that was what was required to rebuild everything. |
|
📌 Commit 61b1650 has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
Jun 12, 2016
Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #756 Approved by: jtimberman
thesentinels
pushed a commit
that referenced
this pull request
Jun 12, 2016
Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #756 Approved by: jtimberman
thesentinels
pushed a commit
that referenced
this pull request
Jun 12, 2016
This is a change from former behavior when `hab` was used to only install package dependencies. Now it is used in every run to hash all the files and to sign that `FILES` metadata, and to sign the resulting package artifact. Consequently, the `$NO_INSTALL_DEPS` environment variable is used in the `_install_dependency()` function to decide whether or not to install external packages. Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #756 Approved by: jtimberman
thesentinels
pushed a commit
that referenced
this pull request
Jun 12, 2016
Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #756 Approved by: jtimberman
thesentinels
pushed a commit
that referenced
this pull request
Jun 12, 2016
Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #756 Approved by: jtimberman
thesentinels
pushed a commit
that referenced
this pull request
Jun 12, 2016
Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #756 Approved by: jtimberman
thesentinels
pushed a commit
that referenced
this pull request
Jun 12, 2016
This is not a full solution, but this plan will no longer build if it takes a dependency on `core/hab-bpm`. A later change will restore the hooks to use template data vs. a shell out to the filesystem. Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #756 Approved by: jtimberman
thesentinels
pushed a commit
that referenced
this pull request
Jun 12, 2016
Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #756 Approved by: jtimberman
thesentinels
pushed a commit
that referenced
this pull request
Jun 12, 2016
Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #756 Approved by: jtimberman
|
☀️ Test successful - travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.