Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plan debugging documentation. #768

Merged
merged 1 commit into from
Jun 12, 2016
Merged

Add plan debugging documentation. #768

merged 1 commit into from
Jun 12, 2016

Conversation

juliandunn
Copy link
Contributor

Also:

  • Fixed a small bug in hab-plan-build where "whereami" doesn't work due to a typo.
  • Moved "build packages" under the create topic; it's really a subset of that.

@davidwrede
Copy link

Agree on the move of the "build packages" content. Now we're really telling a story on the two halves of Habitat: The buildtime dev experience and the runtime management/configuration experience.

@@ -1089,8 +1089,8 @@ attach() {
case "$cmd" in
vars) (set -o posix; set);;
whereami*|\@*)
__attach_whereami "$(echo $cmd \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, what was up there?

@fnichol
Copy link
Collaborator

fnichol commented Jun 12, 2016

Yep, this is great! @juliandunn, looks like this needs a rebase then I'll approve

Fixed a small bug in hab-plan-build where "whereami" doesn't work due
to a typo.
Moved "build packages" under the create topic; it's really a subset of
that.

Signed-off-by: Julian C. Dunn <[email protected]>
@juliandunn
Copy link
Contributor Author

thanks for the review @fnichol ; r+ this anytime

@fnichol
Copy link
Collaborator

fnichol commented Jun 12, 2016

@thesentinels r+

@thesentinels
Copy link
Contributor

📌 Commit 720d8b1 has been approved by fnichol

@thesentinels
Copy link
Contributor

⌛ Testing commit 720d8b1 with merge 882437e...

thesentinels pushed a commit that referenced this pull request Jun 12, 2016
Fixed a small bug in hab-plan-build where "whereami" doesn't work due
to a typo.
Moved "build packages" under the create topic; it's really a subset of
that.

Signed-off-by: Julian C. Dunn <[email protected]>

Pull request: #768
Approved by: fnichol
@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit 720d8b1 into habitat-sh:master Jun 12, 2016
@juliandunn juliandunn deleted the document-plan-creation-debugging branch June 13, 2016 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants