Remove use of Hab bpm in rails plan #770
Conversation
Signed-off-by: jtimberman <[email protected]>
|
By analyzing the blame information on this pull request, we identified @fnichol and @juliandunn to be potential reviewers |
jtimberman
changed the title
|
📌 Commit f97cec1 has been approved by |
Signed-off-by: jtimberman <[email protected]> Pull request: #770 Approved by: reset
|
☀️ Test successful - travis |
| @@ -12,8 +12,8 @@ echo "Linking database.yml" | |||
| ln -sf {{pkg.svc_config_path}}/database.yml ${RAILS_SAMPLE_DATA}/dist/config/database.yml | |||
|
|
|||
| export GEM_HOME="${RAILS_SAMPLE_DATA}/dist/vendor/bundle/ruby/2.3.0" | |||
| export GEM_PATH="$(hab-bpm pkgpath core/ruby)/lib/ruby/gems/2.3.0:$(hab-bpm pkgpath core/bundler):$GEM_HOME" | |||
| export LD_LIBRARY_PATH="$(hab-bpm pkgpath core/gcc-libs)/lib" | |||
There was a problem hiding this comment.
I'd rather see us use templating data here, could we give this a try? You are not guaranteed to get the version of core/ruby and core/gcc-libs that you were built with--you could even get nothing back. The only sure way is via the packaging metadata we get back from the supervisor.
There was a problem hiding this comment.
It's also not guarenteed that hab will even be on your $PATH when the hook fires--the Supervisor will ensure your package's PATH entries are on $PATH along with the Supervisor's own dependencies, but the Supervisor doesn't have a dependency on core/hab. Anyway, I'm writing this to future self too so I don't forget.
Remove use of Hab bpm and use Hab for package path.