Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial draft of HTTP API docs #773

Merged
merged 1 commit into from
Jun 14, 2016
Merged

Initial draft of HTTP API docs #773

merged 1 commit into from
Jun 14, 2016

Conversation

davidwrede
Copy link

  • MVP version of monitoring "how to" doc
  • Also fixed formatting issue in run-packages-overview topic

Feel free to leave comments on the how to topic while I flesh out the ref topic. Once the ref topic is done, I'll add it to this PR.

Signed-off-by: David Wrede [email protected]

@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @juliandunn, @TrevorBramble and @ryankeairns to be potential reviewers

# Monitor services through the HTTP API
When a service starts, the supervisor exposes the status of leader elections, gossip rumors, health, and other information through an HTTP API endpoint. This information can be useful in monitoring service health, results of leader elections, and so on.

Every supervisor has an HTTP API that provides information on:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the phraseology isn't quite right, because the user is expecting to read a list of nouns and instead gets handed a set of endpoints. Maybe just something like "The HTTP API provides a variety of information on the following endpoints"

@juliandunn
Copy link
Contributor

Looks good overall; as a stretch goal I would say to show examples of each type of content

@thesentinels
Copy link
Contributor

☔ The latest upstream changes (presumably 1428c85) made this pull request unmergeable. Please resolve the merge conflicts.

@juliandunn
Copy link
Contributor

you want to rebase this and then we can take it?

@davidwrede
Copy link
Author

davidwrede commented Jun 13, 2016

Sure. I'll add the ref content in another PR.

Also squashing a couple commits.

@juliandunn
Copy link
Contributor

cool, let's take it

@thesentinels r+

@thesentinels
Copy link
Contributor

📌 Commit 6f01292 has been approved by juliandunn

@thesentinels
Copy link
Contributor

⌛ Testing commit 6f01292 with merge 206da6e...

thesentinels pushed a commit that referenced this pull request Jun 13, 2016
Signed-off-by: David Wrede <[email protected]>

Pull request: #773
Approved by: juliandunn
@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit 6f01292 into habitat-sh:master Jun 14, 2016
@juliandunn juliandunn deleted the dw/HTTP_API_docs branch June 14, 2016 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants