Streamlined tutorial and fixed broken links #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @cwebberOps, @ryankeairns, @nathenharvey, @larryebaum and @mattray to be potential reviewers |
| # The mytutorialapp source code is unpacked into a directory, | ||
| # mytutorialapp-0.1.0, at the root of $HAB_CACHE_SRC_PATH. If you were downloading | ||
| # an archive that didn't match your package name and version, you would have to | ||
| # copy the files from the extracts directory to $HAB_CACHE_SRC_PATH. |
There was a problem hiding this comment.
"the extracts directory" seems like new vocabulary. Could we say, "from $HAB_CACHE_SRC_PATH, the directory into which the files were extracted", or something like that.
There was a problem hiding this comment.
Good catch. It was a copy-paste-edit mishap.
added 2 commits
June 13, 2016 12:04
Signed-off-by: David Wrede <[email protected]>
Signed-off-by: David Wrede <[email protected]>
|
Feedback is in. |
|
📌 Commit c3f4607 has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
Jun 13, 2016
Signed-off-by: David Wrede <[email protected]> Pull request: #784 Approved by: davidwrede
thesentinels
pushed a commit
that referenced
this pull request
Jun 13, 2016
Signed-off-by: David Wrede <[email protected]> Pull request: #784 Approved by: davidwrede
|
☀️ Test successful - travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Wrede [email protected]