Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change bldr/simple_service references to chef/simple_service #79

Merged
merged 1 commit into from
Nov 16, 2015

Conversation

reset
Copy link
Collaborator

@reset reset commented Nov 15, 2015

Don't merge just yet. There is still something wrong with the functional test suite being unable to locate the chef/simple_service docker image.

@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@fnichol
Copy link
Collaborator

fnichol commented Nov 16, 2015

Think I've got this: I added an explicit pkg_derivation=test in the simple_service plan. I'll crunch and re-push to this branch for another round of testing.

@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@fnichol
Copy link
Collaborator

fnichol commented Nov 16, 2015

The above commit doesn't fix 100% of the failures, but we have a solid lead on why:

When a service writes to its key space in discovery, it's writing under bldr and not to the derivative of the package. In the failing functionals, we see a bldr and a test key at the root of etcd.

Given the above, we're closer to passing functionals and we should be okay to merge this.

@fnichol
Copy link
Collaborator

fnichol commented Nov 16, 2015

@delivery approve

chef-delivery added a commit that referenced this pull request Nov 16, 2015
Merged change 49b37dad-0372-40f9-ad34-3df8c460e1b6

From review branch fix-tests into master

Signed-off-by: fnichol <[email protected]>
@chef-delivery chef-delivery merged commit d22e3a5 into master Nov 16, 2015
@chef-delivery
Copy link
Contributor

Change: 49b37dad-0372-40f9-ad34-3df8c460e1b6 approved by: @fnichol

@chef-delivery chef-delivery deleted the fix-tests branch November 16, 2015 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants