Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hab] Add GitHub access token question to hab cli setup. #801

Merged
merged 1 commit into from
Jun 14, 2016

Conversation

fnichol
Copy link
Collaborator

@fnichol fnichol commented Jun 13, 2016

No description provided.

@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @juliandunn to be a potential reviewer

@fnichol
Copy link
Collaborator Author

fnichol commented Jun 13, 2016

@juliandunn This should be ready to go, if you're happy, merge away!

@juliandunn
Copy link
Contributor

@fnichol just want to make sure: the places in the rest of the code that consume this (i.e. the authenticated operations) do actually look in hab's config file for this value?

@juliandunn
Copy link
Contributor

alright, confirmed verbally with fnichol that it is wired in.

@thesentinels r+

@thesentinels
Copy link
Contributor

📌 Commit 0870d6b has been approved by juliandunn

@thesentinels
Copy link
Contributor

⌛ Testing commit 0870d6b with merge cc5ca2b...

thesentinels pushed a commit that referenced this pull request Jun 14, 2016
Signed-off-by: Fletcher Nichol <[email protected]>

Pull request: #801
Approved by: juliandunn
@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit 0870d6b into master Jun 14, 2016
@fnichol fnichol deleted the fnichol/hab-setup-token branch June 14, 2016 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants