Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plans/openvpn] Add service management #815

Merged
merged 2 commits into from
Jun 14, 2016
Merged

[plans/openvpn] Add service management #815

merged 2 commits into from
Jun 14, 2016

Conversation

jtimberman
Copy link
Contributor

This commit adds service management and configuration for the openvpn plan. A README.md describes how to get the certificates into the running OpenVPN server, too.

Signed-off-by: Jamie Winsor <[email protected]>
@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @adamhjk to be a potential reviewer


# The maximum number of concurrently connected
# clients we want to allow.
max-clients = "100"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be a plain integer?

This commit adds service management and configuration for the openvpn
plan. A README.md describes how to get the certificates into the
running OpenVPN server, too.

Signed-off-by: jtimberman <[email protected]>
@reset
Copy link
Collaborator

reset commented Jun 14, 2016

@thesentinels r+

gif-keyboard-3927208280250200803

@thesentinels
Copy link
Contributor

📌 Commit c5e456b has been approved by reset

thesentinels pushed a commit that referenced this pull request Jun 14, 2016
Signed-off-by: Jamie Winsor <[email protected]>

Pull request: #815
Approved by: reset
thesentinels pushed a commit that referenced this pull request Jun 14, 2016
This commit adds service management and configuration for the openvpn
plan. A README.md describes how to get the certificates into the
running OpenVPN server, too.

Signed-off-by: jtimberman <[email protected]>

Pull request: #815
Approved by: reset
@thesentinels
Copy link
Contributor

⌛ Testing commit c5e456b with merge cc341ca...

@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit c5e456b into master Jun 14, 2016
@jtimberman jtimberman deleted the openvpn-plan branch June 17, 2016 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants