Fix functionals by uploading to correct discovery path. #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A key bit of learning (for me) is that the `bldr` key in the root of the etcd tree is to describe all things bldr, *not* the service's derivation.
|
|
|
This PR has passed 'Verify' and is ready for review and approval! |
|
@delivery approve |
chef-delivery
added a commit
that referenced
this pull request
Nov 16, 2015
Merged change dcffbe65-2af2-4e15-b475-5677840badc0 From review branch functional-is-a-go into master Signed-off-by: reset <[email protected]>
|
Change: dcffbe65-2af2-4e15-b475-5677840badc0 approved by: @reset |
|
This PR has passed 'Acceptance' and is ready to be delivered! |
|
@delivery deliver
|
|
Failed to unknown change: dcffbe65-2af2-4e15-b475-5677840badc0 |
|
😿 Guess there's one more round to wait for |
raskchanky
pushed a commit
that referenced
this pull request
Apr 16, 2019
Uses tempfile instead of tempdir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A key bit of learning (for me) is that the
bldrkey in the root of theetcd tree is to describe all things bldr, not the service's
derivation. I see what you did there!