-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Open Graph & Twitter Card tags, image #844
Conversation
Signed-off-by: Trevor Bramble <[email protected]>
By analyzing the blame information on this pull request, we identified @cwebberOps, @ryankeairns and @magwalk to be potential reviewers |
@TrevorBramble do you think we should add these to https://github.com/habitat-sh/habitat/blob/master/components/builder-web/index.html? |
@smith Hm, I suppose so. Want me to include it here? (Feel free to push to this branch yourself if you want.) |
@TrevorBramble please do! Thanks! |
(And amended the current page URL fetching in Middleman.) Signed-off-by: Trevor Bramble <[email protected]>
<meta property="og:title" content="Habitat - Automation that travels with the app."> | ||
<meta property="og:type" content="website"> | ||
<meta property="og:image" content="/assets/images/habitat-social.jpg"> | ||
<meta property="og:url" content="https://www.habitat.sh/"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smith I don't know if it's important but all of the stats for shares under the app will be consolidated to this one URL. Don't know if there are Angularine ways to address that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes let's leave it like this for now and perhaps we can figure out how to do fancier things later.
📌 Commit d5df5a1 has been approved by |
Signed-off-by: Trevor Bramble <[email protected]> Pull request: #844 Approved by: smith
(And amended the current page URL fetching in Middleman.) Signed-off-by: Trevor Bramble <[email protected]> Pull request: #844 Approved by: smith
☀️ Test successful - travis |
Signed-off-by: Trevor Bramble [email protected]