Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Open Graph & Twitter Card tags, image #844

Merged
merged 2 commits into from
Jun 15, 2016
Merged

Conversation

TrevorBramble
Copy link
Contributor

Signed-off-by: Trevor Bramble [email protected]

@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @cwebberOps, @ryankeairns and @magwalk to be potential reviewers

@smith
Copy link
Contributor

smith commented Jun 14, 2016

@TrevorBramble
Copy link
Contributor Author

@smith Hm, I suppose so. Want me to include it here? (Feel free to push to this branch yourself if you want.)

@smith
Copy link
Contributor

smith commented Jun 14, 2016

@TrevorBramble please do! Thanks!

(And amended the current page URL fetching in Middleman.)

Signed-off-by: Trevor Bramble <[email protected]>
<meta property="og:title" content="Habitat - Automation that travels with the app.">
<meta property="og:type" content="website">
<meta property="og:image" content="/assets/images/habitat-social.jpg">
<meta property="og:url" content="https://www.habitat.sh/">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smith I don't know if it's important but all of the stats for shares under the app will be consolidated to this one URL. Don't know if there are Angularine ways to address that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes let's leave it like this for now and perhaps we can figure out how to do fancier things later.

@smith
Copy link
Contributor

smith commented Jun 15, 2016

gif-keyboard-4093673015185949059

@thesentinels r+

@thesentinels
Copy link
Contributor

📌 Commit d5df5a1 has been approved by smith

@thesentinels
Copy link
Contributor

⌛ Testing commit d5df5a1 with merge e932b07...

thesentinels pushed a commit that referenced this pull request Jun 15, 2016
Signed-off-by: Trevor Bramble <[email protected]>

Pull request: #844
Approved by: smith
thesentinels pushed a commit that referenced this pull request Jun 15, 2016
(And amended the current page URL fetching in Middleman.)

Signed-off-by: Trevor Bramble <[email protected]>

Pull request: #844
Approved by: smith
@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit d5df5a1 into master Jun 15, 2016
@TrevorBramble TrevorBramble deleted the open-graph-etc branch October 30, 2016 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants