Add varnish plan #854
Closed
Add varnish plan #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @adamhjk to be a potential reviewer |
| do_install() { | ||
| do_default_install | ||
| mkdir -p $pkg_svc_var_path/habitat_varnish | ||
| chmod 777 $pkg_svc_var_path/habitat_varnish |
There was a problem hiding this comment.
Probably don't want world write. 755 perhaps?
There was a problem hiding this comment.
So I was wondering what the right thing to do with this is... Is umask better than chmod 755? chmod? Not quite sure about how to configure the hab environment's umask, but I figured chmod might be a good start?
|
Feel free to comment about the config.. it's bare-bones right now.
|
| @@ -0,0 +1,41 @@ | |||
| pkg_origin=loom | |||
Signed-off-by: Kevin J. Dickerson <[email protected]> Change origin to core, reduce chmod privileges Signed-off-by: Kevin J. Dickerson <[email protected]> Revert chmod permissions to 777 Signed-off-by: Kevin J. Dickerson <[email protected]>
|
Looks like this fork is no longer available to review. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin J. Dickerson [email protected]