Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken link #859

Merged
merged 3 commits into from
Jun 16, 2016
Merged

fix broken link #859

merged 3 commits into from
Jun 16, 2016

Conversation

leonhartX
Copy link
Contributor

Signed-off-by: Ke Xu [email protected]

Signed-off-by: Ke Xu <[email protected]>
@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @ryankeairns, @cwebberOps, @davidwrede, @smith and @juliandunn to be potential reviewers

<hr>
<ul class="main-content--link-nav">
<li>Continue to the next topic</li>
<li><a href="/docs/nternals-overview">Habitat internals</a></li>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you're missing an "i" in /docs/nternals-overview.

@davidwrede
Copy link

@leonhartX, thanks so much for fixing the broken links and adding in the transition links! I left a comment on one transition link, but other than that, this looks great.

Signed-off-by: Ke Xu <[email protected]>
@leonhartX
Copy link
Contributor Author

@davidwrede thanks for review, have fixed that typo.

@smith
Copy link
Contributor

smith commented Jun 16, 2016

@thesentinels r+

gif-keyboard-5836740274201093045

@thesentinels
Copy link
Contributor

📌 Commit d9e098f has been approved by smith

@thesentinels
Copy link
Contributor

⌛ Testing commit d9e098f with merge 89379e4...

thesentinels pushed a commit that referenced this pull request Jun 16, 2016
Signed-off-by: Ke Xu <[email protected]>

Pull request: #859
Approved by: smith
thesentinels pushed a commit that referenced this pull request Jun 16, 2016
thesentinels pushed a commit that referenced this pull request Jun 16, 2016
Signed-off-by: Ke Xu <[email protected]>

Pull request: #859
Approved by: smith
@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit d9e098f into habitat-sh:master Jun 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants