Open forums and slack in new tab #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Keairns <[email protected]>
|
By analyzing the blame information on this pull request, we identified @magwalk to be a potential reviewer |
|
📌 Commit ab1e78e has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
Jun 15, 2016
Signed-off-by: Ryan Keairns <[email protected]> Pull request: #868 Approved by: juliandunn
|
☀️ Test successful - travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the community page you can open the forums and slack - neither of which have a clear path back to the website. This change simply makes it so that those things open in a new tab which seems appropriate since they are external links to a Discourse instance and Slack, respectively.
We did not make the app link (Search Packages) open in a new tab since that feels more connected to the site, the app nav has links back to docs & tuts, and that once you get into the product you'll likely not return to the website home page very often.
Signed-off-by: Ryan Keairns [email protected]