Add optional binding to haproxy config #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated haproxy.conf to use a binding named backend if one is available. If not, it falls back to the original config values. This allows haproxy to automatically add all members of a service group as backends. Signed-off-by: Nolan Davidson <[email protected]>
|
By analyzing the blame information on this pull request, we identified @kevindickerson and @adamhjk to be potential reviewers |
|
Nice!
|
|
📌 Commit 51329c1 has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
Jun 22, 2016
Updated haproxy.conf to use a binding named backend if one is available. If not, it falls back to the original config values. This allows haproxy to automatically add all members of a service group as backends. Signed-off-by: Nolan Davidson <[email protected]> Pull request: #901 Approved by: smith
|
☀️ Test successful - travis |
|
Built and uploaded to the depot as: https://willem.habitat.sh/#/pkgs/core/haproxy/1.6.5/20160622150401 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated haproxy.conf to use a binding named backend if one is available. If not, it falls back to the original config values. This allows haproxy to automatically add all members of a service group as backends.
Signed-off-by: Nolan Davidson [email protected]