Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse order of installed output statement #909

Merged
merged 1 commit into from
Jun 17, 2016

Conversation

miketheman
Copy link
Contributor

When installing dependencies, reading the language doesn't make a ton of sense.

Before:

→ Using core/which/2.21/20160612155441
→ Using core/zlib/1.2.8/20160612064520
→ Using miketheman/custompkg which satisfies miketheman/custompkg/0.1.0/20160617171833

After:

→ Using core/which/2.21/20160612155441
→ Using core/zlib/1.2.8/20160612064520
→ Using miketheman/custompkg/0.1.0/20160617171833 which satisfies miketheman/custompkg

When installing dependencies, reading the language doesn't make a ton of sense.

Before:
```
→ Using core/which/2.21/20160612155441
→ Using core/zlib/1.2.8/20160612064520
→ Using miketheman/custompkg which satisfies miketheman/custompkg/0.1.0/20160617171833
```

After:
```
→ Using core/which/2.21/20160612155441
→ Using core/zlib/1.2.8/20160612064520
→ Using miketheman/custompkg/0.1.0/20160617171833 which satisfies miketheman/custompkg
```
@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @fnichol, @reset and @metadave to be potential reviewers

@reset
Copy link
Collaborator

reset commented Jun 17, 2016

@miketheman nice catch, I just got used to seeing this wrong :)

@thesentinels r+

@thesentinels
Copy link
Contributor

📌 Commit 65a9089 has been approved by reset

@thesentinels
Copy link
Contributor

⌛ Testing commit 65a9089 with merge 9576016...

thesentinels pushed a commit that referenced this pull request Jun 17, 2016
When installing dependencies, reading the language doesn't make a ton of sense.

Before:
```
→ Using core/which/2.21/20160612155441
→ Using core/zlib/1.2.8/20160612064520
→ Using miketheman/custompkg which satisfies miketheman/custompkg/0.1.0/20160617171833
```

After:
```
→ Using core/which/2.21/20160612155441
→ Using core/zlib/1.2.8/20160612064520
→ Using miketheman/custompkg/0.1.0/20160617171833 which satisfies miketheman/custompkg
```
Pull request: #909
Approved by: reset
@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit 65a9089 into habitat-sh:master Jun 17, 2016
@miketheman miketheman deleted the patch-1 branch June 17, 2016 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants